Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 40147: Allow HTML select elements to work in the Windows test_shell (Closed)

Created:
11 years, 9 months ago by Paul Godavari
Modified:
9 years, 7 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Allow HTML select elements to work in the Windows test_shell. Setting the focus after the WebWidget handles the input event instantly closes the popup menu created by the select control. This change allows the popup menus to appear after one click (as expected) and does not trigger the issue where the main page never regains keyboard focus. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M webkit/tools/test_shell/webwidget_host_win.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Godavari
11 years, 9 months ago (2009-03-05 01:57:07 UTC) #1
ojan
11 years, 9 months ago (2009-03-05 02:27:06 UTC) #2
Sweet! Thanks for fixing this.

Powered by Google App Engine
This is Rietveld 408576698