Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: webkit/tools/test_shell/webwidget_host_win.cc

Issue 40147: Allow HTML select elements to work in the Windows test_shell (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/webwidget_host_win.cc
===================================================================
--- webkit/tools/test_shell/webwidget_host_win.cc (revision 10621)
+++ webkit/tools/test_shell/webwidget_host_win.cc (working copy)
@@ -283,6 +283,11 @@
break;
case WebInputEvent::MOUSE_DOWN:
SetCapture(view_);
+ // This mimics a temporary workaround in RenderWidgetHostViewWin
+ // for bug 765011 to get focus when the mouse is clicked. This
+ // happens after the mouse down event is sent to the renderer
+ // because normally Windows does a WM_SETFOCUS after WM_LBUTTONDOWN.
+ ::SetFocus(view_);
break;
case WebInputEvent::MOUSE_UP:
if (GetCapture() == view_)
@@ -290,14 +295,6 @@
break;
}
webwidget_->HandleInputEvent(&event);
-
- if (event.type == WebInputEvent::MOUSE_DOWN) {
- // This mimics a temporary workaround in RenderWidgetHostViewWin
- // for bug 765011 to get focus when the mouse is clicked. This
- // happens after the mouse down event is sent to the renderer
- // because normally Windows does a WM_SETFOCUS after WM_LBUTTONDOWN.
- ::SetFocus(view_);
- }
}
void WebWidgetHost::WheelEvent(WPARAM wparam, LPARAM lparam) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698