Correction of return parameter validation for popup.getParentWindow, and extension.getPopupView.

Addition of "optional" tag to chrome.exerpimental.popup routines that may return an undefined value.chrome.experimental.extension.getPopupView() may return undefined if no pop-up is currently displayed.chrome.experimental.popup.getParentWindow() may return undefined if called from a non-popup view.BUG=28045
TEST=extension_popup_apitest.cc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32387

[rafaelw, 2009-11-17 23:59:26]

lgtm.

nit: note in the description for the docs here that these functions will return
undefined if there "isn't one".

[Jeff Timanus, 2009-11-18 18:23:39]

Thanks Rafael.

I added some relevant unit-tests, if you also want to take a look at those.

Jeff

On 2009/11/17 23:59:26, rafaelw wrote:
> lgtm.
> 
> nit: note in the description for the docs here that these functions will
return
> undefined if there "isn't one".

[rafaelw1, 2009-11-18 18:40:54]

nice

On Wed, Nov 18, 2009 at 10:23 AM,  <twiz@chromium.org> wrote:
> Thanks Rafael.
>
> I added some relevant unit-tests, if you also want to take a look at those.
>
> Jeff
>
> On 2009/11/17 23:59:26, rafaelw wrote:
>>
>> lgtm.
>
>> nit: note in the description for the docs here that these functions will
>
> return
>>
>> undefined if there "isn't one".
>
>
>
> http://codereview.chromium.org/400023
>