Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4382)

Unified Diff: chrome/common/extensions/api/extension_api.json

Issue 400023: Correction of return parameter validation for popup.getParentWindow, and extension.getPopupView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/popup_api/toolband.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/extension_api.json
===================================================================
--- chrome/common/extensions/api/extension_api.json (revision 32240)
+++ chrome/common/extensions/api/extension_api.json (working copy)
@@ -210,13 +210,14 @@
{
"name": "getPopupView",
"type": "function",
- "description": "Returns a reference to the window object of the popup view.",
+ "description": "Returns a reference to the window object of the popup view. Returns undefined if no popup presently shown.",
"parameters": [],
"returns": {
"type": "object",
"isInstanceOf": "DOMWindow",
"properties": {},
- "additionalProperties": { "type": "any" }
+ "additionalProperties": { "type": "any" },
+ "optional": true
}
}
],
@@ -1678,13 +1679,14 @@
{
"name": "getParentWindow",
"type": "function",
- "description": "Returns a reference to the window object of the extension view that launched the popup.",
+ "description": "Returns a reference to the window object of the extension view that launched the popup. Returns undefined if called outside of a popup window.",
"parameters": [],
"returns": {
"type": "object",
"isInstanceOf": "DOMWindow",
"properties": {},
- "additionalProperties": { "type": "any" }
+ "additionalProperties": { "type": "any" },
+ "optional": true
}
}
],
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/popup_api/toolband.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698