Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 39182: DevToolsAgent crash fixed: reset RenderView when it's destroyed (Closed)

Created:
11 years, 9 months ago by yurys
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

- DevToolsAgent is notified in render thread when RenderView is being detroyed. - Methods of RenderView are called only on render thread in DevToolsAgent(earlier routing_id() was called on IO thread) BUG=8378 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10980

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/renderer/dev_tools_agent.h View 1 2 chunks +5 lines, -0 lines 1 comment Download
M chrome/renderer/dev_tools_agent.cc View 6 chunks +13 lines, -3 lines 3 comments Download
M chrome/renderer/render_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
11 years, 9 months ago (2009-03-05 09:58:24 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/39182/diff/1/3 File chrome/renderer/dev_tools_agent.h (right): http://codereview.chromium.org/39182/diff/1/3#newcode63 Line 63: int routing_id_; // View routing id that ...
11 years, 9 months ago (2009-03-05 10:14:49 UTC) #2
yurys
http://codereview.chromium.org/39182/diff/1/3 File chrome/renderer/dev_tools_agent.h (right): http://codereview.chromium.org/39182/diff/1/3#newcode63 Line 63: int routing_id_; // View routing id that we ...
11 years, 9 months ago (2009-03-05 10:43:29 UTC) #3
Dean McNamee
11 years, 9 months ago (2009-03-05 11:43:29 UTC) #4
http://codereview.chromium.org/39182/diff/9/1005
File chrome/renderer/dev_tools_agent.cc (right):

http://codereview.chromium.org/39182/diff/9/1005#newcode29
Line 29: // Called on render thread.
on the render thread

http://codereview.chromium.org/39182/diff/9/1005#newcode80
Line 80: // Called on IO thread.
on the IO thread.

http://codereview.chromium.org/39182/diff/9/1005#newcode92
Line 92: // view_ may have been cleared after this method execution was
scheduled.
|view_|

http://codereview.chromium.org/39182/diff/9/1004
File chrome/renderer/dev_tools_agent.h (right):

http://codereview.chromium.org/39182/diff/9/1004#newcode63
Line 63: int routing_id_; //  View routing id that we can access from IO thread.
This is a style violation, two spaces before //

Powered by Google App Engine
This is Rietveld 408576698