Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: chrome/renderer/render_view.cc

Issue 39182: DevToolsAgent crash fixed: reset RenderView when it's destroyed (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/render_view.h" 5 #include "chrome/renderer/render_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 194
195 resource_dispatcher_->ClearMessageSender(); 195 resource_dispatcher_->ClearMessageSender();
196 // Clear any back-pointers that might still be held by plugins. 196 // Clear any back-pointers that might still be held by plugins.
197 PluginDelegateList::iterator it = plugin_delegates_.begin(); 197 PluginDelegateList::iterator it = plugin_delegates_.begin();
198 while (it != plugin_delegates_.end()) { 198 while (it != plugin_delegates_.end()) {
199 (*it)->DropRenderView(); 199 (*it)->DropRenderView();
200 it = plugin_delegates_.erase(it); 200 it = plugin_delegates_.erase(it);
201 } 201 }
202 202
203 render_thread_->RemoveFilter(debug_message_handler_); 203 render_thread_->RemoveFilter(debug_message_handler_);
204
205 dev_tools_agent_->RenderViewDestroyed();
204 render_thread_->RemoveFilter(dev_tools_agent_); 206 render_thread_->RemoveFilter(dev_tools_agent_);
205 207
206 #ifdef CHROME_PERSONALIZATION 208 #ifdef CHROME_PERSONALIZATION
207 Personalization::CleanupRendererPersonalization(personalization_); 209 Personalization::CleanupRendererPersonalization(personalization_);
208 personalization_ = NULL; 210 personalization_ = NULL;
209 #endif 211 #endif
210 } 212 }
211 213
212 /*static*/ 214 /*static*/
213 RenderView* RenderView::Create( 215 RenderView* RenderView::Create(
(...skipping 2758 matching lines...) Expand 10 before | Expand all | Expand 10 after
2972 DCHECK(audio_renderers_.Lookup(stream_id) != NULL); 2974 DCHECK(audio_renderers_.Lookup(stream_id) != NULL);
2973 Send(new ViewHostMsg_SetAudioVolume(routing_id_, stream_id, left, right)); 2975 Send(new ViewHostMsg_SetAudioVolume(routing_id_, stream_id, left, right));
2974 } 2976 }
2975 2977
2976 void RenderView::OnResize(const gfx::Size& new_size, 2978 void RenderView::OnResize(const gfx::Size& new_size,
2977 const gfx::Rect& resizer_rect) { 2979 const gfx::Rect& resizer_rect) {
2978 if (webview()) 2980 if (webview())
2979 webview()->HideAutofillPopup(); 2981 webview()->HideAutofillPopup();
2980 RenderWidget::OnResize(new_size, resizer_rect); 2982 RenderWidget::OnResize(new_size, resizer_rect);
2981 } 2983 }
OLDNEW
« chrome/renderer/dev_tools_agent.cc ('K') | « chrome/renderer/dev_tools_agent.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698