DevToolsAgent crash fixed: reset RenderView when it's destroyed

chrome/renderer/dev_tools_agent.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_DEV_TOOLS_AGENT_H_
 #define CHROME_RENDERER_DEV_TOOLS_AGENT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 10 matching lines @@
 // go through browser process. On the renderer side of the tools UI there's
 // a corresponding ToolsClient object.
 class DevToolsAgent : public IPC::ChannelProxy::MessageFilter,
                       public DebuggerBridge::Delegate {
  public:
   // DevToolsAgent is a field of the RenderView. The view is supposed to remove
   // this agent from message filter list on IO thread before dying.
   explicit DevToolsAgent(RenderView* view, MessageLoop* view_loop);
   virtual ~DevToolsAgent();
 
+  // DevToolsAgent is created by RenderView which is supposed to call this
+  // method from its destructor.
+  void RenderViewDestroyed();
+
  private:
   // Sends message to DevToolsClient. May be called on any thread.
   void Send(const IPC::Message& tools_client_message);
 
   // Sends message to DevToolsClient. Must be called on IO thread. Takes
   // ownership of the message.
   void SendFromIOThread(IPC::Message* message);
 
   // IPC::ChannelProxy::MessageFilter overrides. Called on IO thread.
   virtual void OnFilterAdded(IPC::Channel* channel);
   virtual bool OnMessageReceived(const IPC::Message& message);
   virtual void OnFilterRemoved();
 
   // Debugger::Delegate callback method to handle debugger output.
   void DebuggerOutput(const std::wstring& out);
 
   // Evaluate javascript URL in the renderer
   void EvaluateScript(const std::wstring& script);
 
   // All these OnXXX methods will be executed in IO thread so that we can
   // handle debug messages even when v8 is stopped.
   void OnDebugAttach();
   void OnDebugDetach();
   void OnDebugBreak(bool force);
   void OnDebugCommand(const std::wstring& cmd);
 
   scoped_refptr<DebuggerBridge> debugger_;
 
+  int routing_id_; //  View routing id that we can access from IO thread.

[Dean McNamee, 2009/03/05 11:43:29]

This is a style violation, two spaces before //

   RenderView* view_;
   MessageLoop* view_loop_;
 
   IPC::Channel* channel_;
   MessageLoop* io_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(DevToolsAgent);
 };
 
 #endif  // CHROME_RENDERER_DEV_TOOLS_AGENT_H_