Add a meaningful name when disassembling code. This makes it easier...

Add a meaningful name when disassembling code. This makes it easier
to match generated code to the originating source.


Committed: http://code.google.com/p/v8/source/detail?r=1408

[Kasper Lund, 2009-03-03 15:42:30]

LGTM.

http://codereview.chromium.org/39014/diff/1/8
File src/code-stubs.cc (right):

http://codereview.chromium.org/39014/diff/1/8#newcode74
Line 74: Print();
Do you want to both Print and Disassemble?

http://codereview.chromium.org/39014/diff/1/5
File src/stub-cache.cc (right):

http://codereview.chromium.org/39014/diff/1/5#newcode914
Line 914: return GetCodeWithFlags(Code::ComputeMonomorphicFlags(Code::LOAD_IC,
type),
Maybe this would look better if you precomputed the flags and stored that in a
local variable? Goes for a lot of code in here.

http://codereview.chromium.org/39014/diff/1/5#newcode941
Line 941: Code::Flags flags = Code::ComputeMonomorphicFlags(Code::CALL_IC, type,
argc);
Yes. Like this.

[iposva, 2009-03-03 16:21:19]

http://codereview.chromium.org/39014/diff/1/8
File src/code-stubs.cc (right):

http://codereview.chromium.org/39014/diff/1/8#newcode74
Line 74: Print();
On 2009/03/03 15:42:30, Kasper Lund wrote:
> Do you want to both Print and Disassemble?

Print just prints the name of the stub, but not the instructions.

http://codereview.chromium.org/39014/diff/1/5
File src/stub-cache.cc (right):

http://codereview.chromium.org/39014/diff/1/5#newcode914
Line 914: return GetCodeWithFlags(Code::ComputeMonomorphicFlags(Code::LOAD_IC,
type),
On 2009/03/03 15:42:30, Kasper Lund wrote:
> Maybe this would look better if you precomputed the flags and stored that in a
> local variable? Goes for a lot of code in here.

Done.

http://codereview.chromium.org/39014/diff/1/5#newcode941
Line 941: Code::Flags flags = Code::ComputeMonomorphicFlags(Code::CALL_IC, type,
argc);
On 2009/03/03 15:42:30, Kasper Lund wrote:
> Yes. Like this.

Done.