Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: src/builtins.cc

Issue 39014: Add a meaningful name when disassembling code. This makes it easier... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | src/code-stubs.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 681 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 if (code->IsFailure()) { 692 if (code->IsFailure()) {
693 v8::internal::V8::FatalProcessOutOfMemory("CreateCode"); 693 v8::internal::V8::FatalProcessOutOfMemory("CreateCode");
694 } 694 }
695 } 695 }
696 // Add any unresolved jumps or calls to the fixup list in the 696 // Add any unresolved jumps or calls to the fixup list in the
697 // bootstrapper. 697 // bootstrapper.
698 Bootstrapper::AddFixup(Code::cast(code), &masm); 698 Bootstrapper::AddFixup(Code::cast(code), &masm);
699 // Log the event and add the code to the builtins array. 699 // Log the event and add the code to the builtins array.
700 LOG(CodeCreateEvent("Builtin", Code::cast(code), functions[i].s_name)); 700 LOG(CodeCreateEvent("Builtin", Code::cast(code), functions[i].s_name));
701 builtins_[i] = code; 701 builtins_[i] = code;
702 #ifdef DEBUG 702 #ifdef ENABLE_DISASSEMBLER
703 if (FLAG_print_builtin_code) { 703 if (FLAG_print_builtin_code) {
704 PrintF("Builtin: %s\n", functions[i].s_name); 704 PrintF("Builtin: %s\n", functions[i].s_name);
705 code->Print(); 705 Code::cast(code)->Disassemble(functions[i].s_name);
706 PrintF("\n"); 706 PrintF("\n");
707 } 707 }
708 #endif 708 #endif
709 } else { 709 } else {
710 // Deserializing. The values will be filled in during IterateBuiltins. 710 // Deserializing. The values will be filled in during IterateBuiltins.
711 builtins_[i] = NULL; 711 builtins_[i] = NULL;
712 } 712 }
713 names_[i] = functions[i].s_name; 713 names_[i] = functions[i].s_name;
714 } 714 }
715 715
(...skipping 19 matching lines...) Expand all
735 if (entry->contains(pc)) { 735 if (entry->contains(pc)) {
736 return names_[i]; 736 return names_[i];
737 } 737 }
738 } 738 }
739 } 739 }
740 return NULL; 740 return NULL;
741 } 741 }
742 742
743 743
744 } } // namespace v8::internal 744 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | src/code-stubs.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698