Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: src/code-stubs.cc

Issue 39014: Add a meaningful name when disassembling code. This makes it easier... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 Code::Flags flags = Code::ComputeFlags(Code::STUB); 61 Code::Flags flags = Code::ComputeFlags(Code::STUB);
62 Handle<Code> code = Factory::NewCode(desc, NULL, flags, masm.CodeObject()); 62 Handle<Code> code = Factory::NewCode(desc, NULL, flags, masm.CodeObject());
63 code->set_major_key(MajorKey()); 63 code->set_major_key(MajorKey());
64 64
65 // Add unresolved entries in the code to the fixup list. 65 // Add unresolved entries in the code to the fixup list.
66 Bootstrapper::AddFixup(*code, &masm); 66 Bootstrapper::AddFixup(*code, &masm);
67 67
68 LOG(CodeCreateEvent("Stub", *code, GetName())); 68 LOG(CodeCreateEvent("Stub", *code, GetName()));
69 Counters::total_stubs_code_size.Increment(code->instruction_size()); 69 Counters::total_stubs_code_size.Increment(code->instruction_size());
70 70
71 #ifdef ENABLE_DISASSEMBLER
72 if (FLAG_print_code_stubs) {
71 #ifdef DEBUG 73 #ifdef DEBUG
72 if (FLAG_print_code_stubs) {
73 Print(); 74 Print();
Kasper Lund 2009/03/03 15:42:30 Do you want to both Print and Disassemble?
iposva 2009/03/03 16:21:19 Print just prints the name of the stub, but not th
74 code->Print(); 75 #endif
76 code->Disassemble(GetName());
75 PrintF("\n"); 77 PrintF("\n");
76 } 78 }
77 #endif 79 #endif
78 80
79 // Update the dictionary and the root in Heap. 81 // Update the dictionary and the root in Heap.
80 Handle<Dictionary> dict = 82 Handle<Dictionary> dict =
81 Factory::DictionaryAtNumberPut(Handle<Dictionary>(Heap::code_stubs()), 83 Factory::DictionaryAtNumberPut(Handle<Dictionary>(Heap::code_stubs()),
82 key, 84 key,
83 code); 85 code);
84 Heap::set_code_stubs(*dict); 86 Heap::set_code_stubs(*dict);
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 case JSExit: 133 case JSExit:
132 return "JSExit"; 134 return "JSExit";
133 default: 135 default:
134 UNREACHABLE(); 136 UNREACHABLE();
135 return NULL; 137 return NULL;
136 } 138 }
137 } 139 }
138 140
139 141
140 } } // namespace v8::internal 142 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/builtins.cc ('k') | src/codegen.cc » ('j') | src/stub-cache.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698