Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 3855001: Move scoped_cftyperef from base to base/mac, use the new namespace, and name ... (Closed)

Created:
10 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
Nico, viettrungluu
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, jam, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Move scoped_cftyperef from base to base/mac, use the new namespace, and name it properly (scoped_cftyperef -> ScopedCFTypeRef). TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -306 lines) Patch
M app/clipboard/clipboard_mac.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M app/surface/accelerated_surface_mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M app/surface/accelerated_surface_mac.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/file_path.cc View 4 chunks +4 lines, -4 lines 0 comments Download
A + base/mac/scoped_cftyperef.h View 2 chunks +19 lines, -12 lines 0 comments Download
M base/mac_util.mm View 12 chunks +17 lines, -15 lines 0 comments Download
M base/mac_util_unittest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M base/native_library_mac.mm View 3 chunks +8 lines, -7 lines 0 comments Download
D base/scoped_cftyperef.h View 1 chunk +0 lines, -80 lines 0 comments Download
M base/scoped_nsobject.h View 2 chunks +8 lines, -8 lines 0 comments Download
M base/sys_string_conversions_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M base/time_mac.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/breakpad_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/animatable_image.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/certificate_viewer.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/download_started_animation_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cocoa/file_metadata.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/install_from_dmg.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/cocoa/page_info_window_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cocoa/shell_dialogs_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/ssl_client_certificate_selector.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cocoa/tab_view.mm View 2 chunks +3 lines, -3 lines 0 comments Download
MM chrome/browser/cocoa/tabpose_window.h View 2 chunks +3 lines, -3 lines 0 comments Download
MM chrome/browser/cocoa/tabpose_window.mm View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/file_path_watcher_mac.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider_mac.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider_mac_unittest.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/preferences_mock_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/backing_store_mac.mm View 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/common/font_loader_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/mach_message_source_mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/mach_message_source_mac.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/sandbox_mac.mm View 4 chunks +5 lines, -5 lines 0 comments Download
MM chrome/common/sandbox_mac_fontloading_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/plugin/plugin_thread.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/plugin/webplugin_proxy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/renderer/print_web_view_helper_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gfx/blit.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gfx/canvas_skia_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/cert_test_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/keygen_handler_mac.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/base/network_change_notifier_mac.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M net/base/network_config_watcher_mac.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/network_config_watcher_mac.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/base/platform_mime_util_mac.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M net/base/ssl_config_service_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/x509_certificate_mac.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/proxy/proxy_config_service_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_mac.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/socket/ssl_client_socket_mac.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M printing/image.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M printing/pdf_metafile_mac.h View 2 chunks +4 lines, -4 lines 0 comments Download
M printing/pdf_metafile_mac.cc View 1 chunk +3 lines, -1 line 0 comments Download
M printing/printed_document_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M printing/printing_context_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M skia/ext/skia_utils_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/plugins/pepper_graphics_2d.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/plugins/pepper_plugin_instance.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/plugins/plugin_lib_mac.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/glue/webcursor_mac.mm View 7 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
10 years, 2 months ago (2010-10-16 15:31:34 UTC) #1
brettw
TBR (want to check in on the weekend). I'm happy to change anything later.
10 years, 2 months ago (2010-10-17 04:08:58 UTC) #2
Nico
Are you going to rename scoped_ptr to ScopedPtr as well? I thought all the scoped_ ...
10 years, 2 months ago (2010-10-18 03:56:33 UTC) #3
brettw
On Sun, Oct 17, 2010 at 8:56 PM, <thakis@chromium.org> wrote: > Are you going to ...
10 years, 2 months ago (2010-10-18 04:36:17 UTC) #4
Nico
10 years, 2 months ago (2010-10-18 04:39:02 UTC) #5
On Sun, Oct 17, 2010 at 9:35 PM, Brett Wilson <brettw@chromium.org> wrote:
> On Sun, Oct 17, 2010 at 8:56 PM,  <thakis@chromium.org> wrote:
>> Are you going to rename scoped_ptr to ScopedPtr as well?
>>
>> I thought all the scoped_ things were named similar to auto_ptr and similar
>> classes in the stl / boost.
>
> What we did for most of the original scoped classes (the windows ones)
> is use Google-style class naming. When this came up at the time (like
> 3 years ago) the feeling was we should use Google-style naming for
> everything except scoped_ptr for consistency with Google3.
> scoped_refptr used to even be RefPtr. RefPtr but had to be renamed
> because of conflicts with WebCore and we went with consistency with
> scoped_ptr rather than invent something weirder. Now we have kind of a
> half-and-half grab bag of naming styles, so I'm changing the ones
> except for scoped_ptr and scoped_refptr to be Google style.

I personally think giving the scoped classes consistent names is
nicer. But I don't really care all that much.

Powered by Google App Engine
This is Rietveld 408576698