Run pychecker over most scripts in depot_tools. Catched a few bugs.

Run pychecker over most scripts in depot_tools. Catched a few bugs.

TEST=unit tests
BUG=none

[M-A Ruel, 2009-11-10 16:53:29]

Reviewers: dpranke,

Description:
Run pychecker over most scripts in depot_tools. Catched a few bugs.

TEST=unit tests
BUG=none

Please review this at http://codereview.chromium.org/385007

Affected files:
   M gcl.py
   M gclient.py
   M gclient_scm.py
   M presubmit_canned_checks.py
   M presubmit_support.py
   M tests/gcl_unittest.py
   M tests/gclient_test.py
   M tests/trychange_unittest.py
   M trychange.py

[M-A Ruel, 2009-11-10 16:59:30]

Reviewers: dpranke,

Description:
Run pychecker over most scripts in depot_tools. Catched a few bugs.

TEST=unit tests
BUG=none

Please review this at http://codereview.chromium.org/385007

Affected files:
   M gcl.py
   M gclient.py
   M gclient_scm.py
   M presubmit_canned_checks.py
   M presubmit_support.py
   M tests/gcl_unittest.py
   M tests/gclient_test.py
   M tests/trychange_unittest.py
   M trychange.py

[M-A Ruel, 2009-11-10 17:09:34]

Reviewers: dpranke,

Description:
Run pychecker over most scripts in depot_tools. Catched a few bugs.

TEST=unit tests
BUG=none

Please review this at http://codereview.chromium.org/385007

Affected files:
   M gcl.py
   M gclient.py
   M gclient_scm.py
   M presubmit_canned_checks.py
   M presubmit_support.py
   M tests/gcl_unittest.py
   M tests/gclient_test.py
   M tests/trychange_unittest.py
   M trychange.py

[Dirk Pranke, 2009-11-10 19:49:24]

One minor point of clarification; LGTM otherwise.

http://codereview.chromium.org/385007/diff/3001/2003
File gclient.py (right):

http://codereview.chromium.org/385007/diff/3001/2003#newcode860
Line 860: deps[d].module_name,
You're sure this file will already be local? (I'm not 100% clear at what points
this code is called).

[Dirk Pranke, 2009-11-10 19:49:42]

One minor point of clarification; LGTM otherwise.


http://codereview.chromium.org/385007/diff/3001/2003
File gclient.py (right):

http://codereview.chromium.org/385007/diff/3001/2003#newcode860
Line 860: deps[d].module_name,
You're sure this file will already be local? (I'm not 100% clear at what
points this code is called).

http://codereview.chromium.org/385007

[M-A Ruel, 2009-11-10 20:02:22]

http://codereview.chromium.org/385007/diff/3001/2003
File gclient.py (right):

http://codereview.chromium.org/385007/diff/3001/2003#newcode860
Line 860: deps[d].module_name,
On 2009/11/10 19:49:24, dpranke wrote:
> You're sure this file will already be local? (I'm not 100% clear at what
points
> this code is called).

If you look at the old code, it was running [svn cat svn://...] and put it in
deps_parent_content. Note this variable is not used afterward (!) So I removed
all this code altogether.

I kept the code to have sub_deps but split it since the previous code was
unreadable.

[M-A Ruel, 2009-11-10 20:02:41]

http://codereview.chromium.org/385007/diff/3001/2003
File gclient.py (right):

http://codereview.chromium.org/385007/diff/3001/2003#newcode860
Line 860: deps[d].module_name,
On 2009/11/10 19:49:24, dpranke wrote:
> You're sure this file will already be local? (I'm not 100% clear at
what points
> this code is called).

If you look at the old code, it was running [svn cat svn://...] and put
it in deps_parent_content. Note this variable is not used afterward (!)
So I removed all this code altogether.

I kept the code to have sub_deps but split it since the previous code
was unreadable.

http://codereview.chromium.org/385007