tests/gcl_unittest.py - Issue 385007: Run pychecker over most scripts in depot_tools. Catched a few bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/gcl_unittest.py

Issue 385007: Run pychecker over most scripts in depot_tools. Catched a few bugs. (Closed)

Patch Set: . Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/gcl_unittest.py

diff --git a/tests/gcl_unittest.py b/tests/gcl_unittest.py

index 59efd84428f63cf1ae581156f1082663fcd19681..f4dbf34adfa52e4f12be1597492e53ecbb95a261 100755

--- a/tests/gcl_unittest.py

+++ b/tests/gcl_unittest.py

@@ -58,7 +58,7 @@ class GclUnittest(GclTestsBase):

'UnknownFiles', 'UploadCL', 'Warn', 'WriteFile',

'gclient_scm', 'gclient_utils', 'getpass', 'main', 'os', 'random', 're',

'shutil', 'string', 'subprocess', 'sys', 'tempfile',

- 'upload', 'urllib2', 'xml',

+ 'upload', 'urllib2',

]

# If this test fails, you should add the relevant test.

self.compareMembers(gcl, members)

« gclient.py ('K') | « presubmit_support.py ('k') | tests/gclient_test.py » ('j') | no next file with comments »