Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3846005: Revert 62918 - net: clean up SSLHostInfo construction.... (Closed)

Created:
10 years, 2 months ago by agl
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org, Alpha Left Google, Sergey Ulanov, amit, ben+cc_chromium.org, dmac, darin-cc_chromium.org, awong, garykac, Paweł Hajdan Jr., pam+watch_chromium.org
Visibility:
Public.

Description

Revert 62918 - net: clean up SSLHostInfo construction. Create an SSLHostInfoFactory interface and plumb it from the HttpCache to the SSLConnectJob. Also, move the SSLHostInfo reference from the ssl_config to being passed to the SSLClientSocket. BUG=none TEST=net_unittests Review URL: http://codereview.chromium.org/3747003 TBR=agl@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -244 lines) Patch
M chrome/browser/net/connection_tester.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/net/service_url_request_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/metrics_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/test/test_server_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M jingle/notifier/base/chrome_async_socket.cc View 1 chunk +1 line, -2 lines 0 comments Download
M jingle/notifier/base/xmpp_client_socket_factory.h View 2 chunks +1 line, -5 lines 0 comments Download
M jingle/notifier/base/xmpp_client_socket_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/base/ssl_config_service.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/base/ssl_host_info.h View 2 chunks +5 lines, -11 lines 0 comments Download
D net/base/ssl_host_info.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M net/http/disk_cache_based_ssl_host_info.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_cache.h View 3 chunks +1 line, -4 lines 0 comments Download
M net/http/http_cache.cc View 3 chunks +1 line, -22 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M net/http/http_network_layer.h View 5 chunks +0 lines, -5 lines 0 comments Download
M net/http/http_network_layer.cc View 9 chunks +1 line, -10 lines 0 comments Download
M net/http/http_network_layer_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M net/http/http_network_session.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/http/http_network_session.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/http/http_network_transaction.h View 2 chunks +2 lines, -0 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/http/http_response_body_drainer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
MM net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_factory.h View 2 chunks +4 lines, -7 lines 0 comments Download
M net/socket/client_socket_factory.cc View 5 chunks +7 lines, -15 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/socket/client_socket_pool_manager.h View 3 chunks +1 line, -4 lines 0 comments Download
M net/socket/client_socket_pool_manager.cc View 4 chunks +0 lines, -5 lines 0 comments Download
M net/socket/socket_test_util.h View 4 chunks +2 lines, -6 lines 0 comments Download
M net/socket/socket_test_util.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M net/socket/ssl_client_socket_mac_factory.h View 1 chunk +1 line, -4 lines 0 comments Download
M net/socket/ssl_client_socket_mac_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/socket/ssl_client_socket_nss.h View 3 chunks +2 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 6 chunks +9 lines, -11 lines 0 comments Download
M net/socket/ssl_client_socket_nss_factory.h View 1 chunk +1 line, -4 lines 0 comments Download
M net/socket/ssl_client_socket_nss_factory.cc View 2 chunks +2 lines, -5 lines 0 comments Download
MM net/socket/ssl_client_socket_pool.h View 6 chunks +2 lines, -9 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 10 chunks +5 lines, -17 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
MM net/socket/ssl_client_socket_unittest.cc View 10 chunks +10 lines, -20 lines 0 comments Download
M net/socket/tcp_client_socket_pool_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/socket_stream/socket_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/spdy/spdy_test_util.h View 3 chunks +0 lines, -3 lines 0 comments Download
M net/tools/fetch/fetch_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_unittest.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/jingle_glue/ssl_socket_adapter.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
agl
10 years, 2 months ago (2010-10-18 13:45:06 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698