Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: net/socket/client_socket_pool_manager.cc

Issue 3846005: Revert 62918 - net: clean up SSLHostInfo construction.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/socket/client_socket_pool_manager.h ('k') | net/socket/socket_test_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // ClientSocketPoolManager manages access to all ClientSocketPools. It's a 5 // ClientSocketPoolManager manages access to all ClientSocketPools. It's a
6 // simple container for all of them. Most importantly, it handles the lifetime 6 // simple container for all of them. Most importantly, it handles the lifetime
7 // and destruction order properly. 7 // and destruction order properly.
8 8
9 #include "net/socket/client_socket_pool_manager.h" 9 #include "net/socket/client_socket_pool_manager.h"
10 10
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 } 49 }
50 } 50 }
51 51
52 } // namespace 52 } // namespace
53 53
54 ClientSocketPoolManager::ClientSocketPoolManager( 54 ClientSocketPoolManager::ClientSocketPoolManager(
55 NetLog* net_log, 55 NetLog* net_log,
56 ClientSocketFactory* socket_factory, 56 ClientSocketFactory* socket_factory,
57 HostResolver* host_resolver, 57 HostResolver* host_resolver,
58 DnsRRResolver* dnsrr_resolver, 58 DnsRRResolver* dnsrr_resolver,
59 SSLHostInfoFactory* ssl_host_info_factory,
60 ProxyService* proxy_service, 59 ProxyService* proxy_service,
61 SSLConfigService* ssl_config_service) 60 SSLConfigService* ssl_config_service)
62 : net_log_(net_log), 61 : net_log_(net_log),
63 socket_factory_(socket_factory), 62 socket_factory_(socket_factory),
64 host_resolver_(host_resolver), 63 host_resolver_(host_resolver),
65 dnsrr_resolver_(dnsrr_resolver), 64 dnsrr_resolver_(dnsrr_resolver),
66 ssl_host_info_factory_(ssl_host_info_factory),
67 proxy_service_(proxy_service), 65 proxy_service_(proxy_service),
68 ssl_config_service_(ssl_config_service), 66 ssl_config_service_(ssl_config_service),
69 tcp_pool_histograms_("TCP"), 67 tcp_pool_histograms_("TCP"),
70 tcp_socket_pool_(new TCPClientSocketPool( 68 tcp_socket_pool_(new TCPClientSocketPool(
71 g_max_sockets, g_max_sockets_per_group, 69 g_max_sockets, g_max_sockets_per_group,
72 &tcp_pool_histograms_, 70 &tcp_pool_histograms_,
73 host_resolver, 71 host_resolver,
74 socket_factory_, 72 socket_factory_,
75 net_log)), 73 net_log)),
76 ssl_pool_histograms_("SSL2"), 74 ssl_pool_histograms_("SSL2"),
77 ssl_socket_pool_(new SSLClientSocketPool( 75 ssl_socket_pool_(new SSLClientSocketPool(
78 g_max_sockets, g_max_sockets_per_group, 76 g_max_sockets, g_max_sockets_per_group,
79 &ssl_pool_histograms_, 77 &ssl_pool_histograms_,
80 host_resolver, 78 host_resolver,
81 dnsrr_resolver, 79 dnsrr_resolver,
82 ssl_host_info_factory,
83 socket_factory, 80 socket_factory,
84 tcp_socket_pool_.get(), 81 tcp_socket_pool_.get(),
85 NULL /* no socks proxy */, 82 NULL /* no socks proxy */,
86 NULL /* no http proxy */, 83 NULL /* no http proxy */,
87 ssl_config_service, 84 ssl_config_service,
88 net_log)), 85 net_log)),
89 tcp_for_socks_pool_histograms_("TCPforSOCKS"), 86 tcp_for_socks_pool_histograms_("TCPforSOCKS"),
90 socks_pool_histograms_("SOCK"), 87 socks_pool_histograms_("SOCK"),
91 tcp_for_http_proxy_pool_histograms_("TCPforHTTPProxy"), 88 tcp_for_http_proxy_pool_histograms_("TCPforHTTPProxy"),
92 tcp_for_https_proxy_pool_histograms_("TCPforHTTPSProxy"), 89 tcp_for_https_proxy_pool_histograms_("TCPforHTTPSProxy"),
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 218
222 std::pair<SSLSocketPoolMap::iterator, bool> ssl_https_ret = 219 std::pair<SSLSocketPoolMap::iterator, bool> ssl_https_ret =
223 ssl_socket_pools_for_https_proxies_.insert( 220 ssl_socket_pools_for_https_proxies_.insert(
224 std::make_pair( 221 std::make_pair(
225 http_proxy, 222 http_proxy,
226 new SSLClientSocketPool( 223 new SSLClientSocketPool(
227 g_max_sockets_per_proxy_server, g_max_sockets_per_group, 224 g_max_sockets_per_proxy_server, g_max_sockets_per_group,
228 &ssl_for_https_proxy_pool_histograms_, 225 &ssl_for_https_proxy_pool_histograms_,
229 host_resolver_, 226 host_resolver_,
230 dnsrr_resolver_, 227 dnsrr_resolver_,
231 ssl_host_info_factory_,
232 socket_factory_, 228 socket_factory_,
233 tcp_https_ret.first->second /* https proxy */, 229 tcp_https_ret.first->second /* https proxy */,
234 NULL /* no socks proxy */, 230 NULL /* no socks proxy */,
235 NULL /* no http proxy */, 231 NULL /* no http proxy */,
236 ssl_config_service_, net_log_))); 232 ssl_config_service_, net_log_)));
237 DCHECK(tcp_https_ret.second); 233 DCHECK(tcp_https_ret.second);
238 234
239 std::pair<HTTPProxySocketPoolMap::iterator, bool> ret = 235 std::pair<HTTPProxySocketPoolMap::iterator, bool> ret =
240 http_proxy_socket_pools_.insert( 236 http_proxy_socket_pools_.insert(
241 std::make_pair( 237 std::make_pair(
(...skipping 14 matching lines...) Expand all
256 SSLSocketPoolMap::const_iterator it = 252 SSLSocketPoolMap::const_iterator it =
257 ssl_socket_pools_for_proxies_.find(proxy_server); 253 ssl_socket_pools_for_proxies_.find(proxy_server);
258 if (it != ssl_socket_pools_for_proxies_.end()) 254 if (it != ssl_socket_pools_for_proxies_.end())
259 return it->second; 255 return it->second;
260 256
261 SSLClientSocketPool* new_pool = new SSLClientSocketPool( 257 SSLClientSocketPool* new_pool = new SSLClientSocketPool(
262 g_max_sockets_per_proxy_server, g_max_sockets_per_group, 258 g_max_sockets_per_proxy_server, g_max_sockets_per_group,
263 &ssl_pool_histograms_, 259 &ssl_pool_histograms_,
264 host_resolver_, 260 host_resolver_,
265 dnsrr_resolver_, 261 dnsrr_resolver_,
266 ssl_host_info_factory_,
267 socket_factory_, 262 socket_factory_,
268 NULL, /* no tcp pool, we always go through a proxy */ 263 NULL, /* no tcp pool, we always go through a proxy */
269 GetSocketPoolForSOCKSProxy(proxy_server), 264 GetSocketPoolForSOCKSProxy(proxy_server),
270 GetSocketPoolForHTTPProxy(proxy_server), 265 GetSocketPoolForHTTPProxy(proxy_server),
271 ssl_config_service_, 266 ssl_config_service_,
272 net_log_); 267 net_log_);
273 268
274 std::pair<SSLSocketPoolMap::iterator, bool> ret = 269 std::pair<SSLSocketPoolMap::iterator, bool> ret =
275 ssl_socket_pools_for_proxies_.insert(std::make_pair(proxy_server, 270 ssl_socket_pools_for_proxies_.insert(std::make_pair(proxy_server,
276 new_pool)); 271 new_pool));
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 // Third parameter is false because |ssl_socket_pools_for_proxies_| use 322 // Third parameter is false because |ssl_socket_pools_for_proxies_| use
328 // socket pools in |http_proxy_socket_pools_| and |socks_socket_pools_|. 323 // socket pools in |http_proxy_socket_pools_| and |socks_socket_pools_|.
329 AddSocketPoolsToList(list, 324 AddSocketPoolsToList(list,
330 ssl_socket_pools_for_proxies_, 325 ssl_socket_pools_for_proxies_,
331 "ssl_socket_pool_for_proxies", 326 "ssl_socket_pool_for_proxies",
332 false); 327 false);
333 return list; 328 return list;
334 } 329 }
335 330
336 } // namespace net 331 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/client_socket_pool_manager.h ('k') | net/socket/socket_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698