Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Unified Diff: net/base/ssl_host_info.h

Issue 3846005: Revert 62918 - net: clean up SSLHostInfo construction.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/ssl_config_service.h ('k') | net/base/ssl_host_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/ssl_host_info.h
===================================================================
--- net/base/ssl_host_info.h (revision 62921)
+++ net/base/ssl_host_info.h (working copy)
@@ -15,10 +15,9 @@
// This information may be stored on disk so does not include keys or session
// information etc. Primarily it's intended for caching the server's
// certificates.
-class SSLHostInfo {
+class SSLHostInfo :
+ public base::RefCountedThreadSafe<SSLHostInfo> {
public:
- virtual ~SSLHostInfo();
-
// Start will commence the lookup. This must be called before any other
// methods. By opportunistically calling this early, it may be possible to
// overlap this object's lookup and reduce latency.
@@ -46,15 +45,10 @@
// this object and the store operation will still complete. This can only be
// called once WaitForDataReady has returned OK or called its callback.
virtual void Set(const std::string& new_data) = 0;
-};
-class SSLHostInfoFactory {
- public:
- virtual ~SSLHostInfoFactory();
-
- // GetForHost returns a fresh, allocated SSLHostInfo for the given hostname
- // or NULL on failure.
- virtual SSLHostInfo* GetForHost(const std::string& hostname) = 0;
+ protected:
+ friend class base::RefCountedThreadSafe<SSLHostInfo>;
+ virtual ~SSLHostInfo() { }
};
} // namespace net
« no previous file with comments | « net/base/ssl_config_service.h ('k') | net/base/ssl_host_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698