Move windows version-related stuff out of base/win_util and into base/win/win...

Move windows version-related stuff out of base/win_util and into base/win/windows_version. Many files now only need to include this instead of all of win_util.

Remove a bunch of unused code from base/win_util. There was a surprising amount.

Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place.

TEST=it compiles
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62694

[Peter Kasting, 2010-10-14 19:53:37]

Mostly copyright date nits but a few real questions

http://codereview.chromium.org/3823002/diff/12004/81006
File app/win_util.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81006#newcode1
app/win_util.cc:1: // Copyright (c) 2009 The Chromium Authors. All rights
reserved.
Nit: 2010

http://codereview.chromium.org/3823002/diff/12004/81008
File base/base_paths_win.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81008#newcode1
base/base_paths_win.cc:1: // Copyright (c) 2006-2008 The Chromium Authors. All
rights reserved.
Nit: 2010

http://codereview.chromium.org/3823002/diff/12004/81010
File base/path_service_unittest.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81010#newcode1
base/path_service_unittest.cc:1: // Copyright (c) 2006-2008 The Chromium
Authors. All rights reserved.
Nit: 2010

http://codereview.chromium.org/3823002/diff/12004/81011
File base/pe_image_unittest.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81011#newcode1
base/pe_image_unittest.cc:1: // Copyright (c) 2006-2008 The Chromium Authors.
All rights reserved.
Nit: 2010

http://codereview.chromium.org/3823002/diff/12004/81017
File base/win_util.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81017#newcode8
base/win_util.cc:8: #include <shobjidl.h>  // Must be before propkey.
Did you mean for these changes and all the code deletions to be in here?

http://codereview.chromium.org/3823002/diff/12004/81018
File base/win_util.h (right):

http://codereview.chromium.org/3823002/diff/12004/81018#newcode24
base/win_util.h:24: // base/win/windows_version.h"
Nit: Unmatched "

http://codereview.chromium.org/3823002/diff/12004/81029
File chrome/browser/google/google_update.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81029#newcode1
chrome/browser/google/google_update.cc:1: // Copyright (c) 2006-2008 The
Chromium Authors. All rights reserved.
Nit: 2010

http://codereview.chromium.org/3823002/diff/12004/81032
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81032#newcode1326
chrome/browser/renderer_host/render_widget_host_view_win.cc:1326: DLOG(ERROR) <<
"KeyEvent " << message << " wParam " << wparam;
Did you mean to leave this in?

http://codereview.chromium.org/3823002/diff/12004/81033
File chrome/browser/shell_integration_win.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81033#newcode253
chrome/browser/shell_integration_win.cc:253: if
(FAILED(property_store->GetValue(PKEY_AppUserModel_ID,
Did you mean for this change and the header changes to be in here?

http://codereview.chromium.org/3823002/diff/12004/81048
File chrome_frame/chrome_launcher_utils.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81048#newcode1
chrome_frame/chrome_launcher_utils.cc:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
Nit: 2010

http://codereview.chromium.org/3823002/diff/12004/81052
File chrome_frame/test/chrome_frame_test_utils.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81052#newcode230
chrome_frame/test/chrome_frame_test_utils.cc:230: } else {
Nit: Could you remove the "else" while here?

http://codereview.chromium.org/3823002/diff/12004/81056
File ipc/ipc_channel_win.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81056#newcode1
ipc/ipc_channel_win.cc:1: // Copyright (c) 2009 The Chromium Authors. All rights
reserved.
Nit: 2010

http://codereview.chromium.org/3823002/diff/12004/81056#newcode22
ipc/ipc_channel_win.cc:22: namespace {
Did you mean for these changes to be in this patch?

http://codereview.chromium.org/3823002/diff/12004/81057
File sandbox/src/integrity_level_test.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81057#newcode1
sandbox/src/integrity_level_test.cc:1: // Copyright (c) 2006-2008 The Chromium
Authors. All rights reserved.
Nit: 2010

http://codereview.chromium.org/3823002/diff/12004/81058
File sandbox/src/policy_broker.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81058#newcode1
sandbox/src/policy_broker.cc:1: // Copyright (c) 2006-2010 The Chromium Authors.
All rights reserved.
Nit: Remove 2006

http://codereview.chromium.org/3823002/diff/12004/81059
File sandbox/src/policy_target_test.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81059#newcode1
sandbox/src/policy_target_test.cc:1: // Copyright (c) 2006-2010 The Chromium
Authors. All rights reserved.
Nit: Remove 2006

http://codereview.chromium.org/3823002/diff/12004/81060
File sandbox/src/registry_dispatcher.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81060#newcode1
sandbox/src/registry_dispatcher.cc:1: // Copyright (c) 2006-2010 The Chromium
Authors. All rights reserved.
Nit: Remove 2006

http://codereview.chromium.org/3823002/diff/12004/81061
File sandbox/src/restricted_token_utils.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81061#newcode1
sandbox/src/restricted_token_utils.cc:1: // Copyright (c) 2006-2008 The Chromium
Authors. All rights reserved.
Nit: 2010

http://codereview.chromium.org/3823002/diff/12004/81061#newcode88
sandbox/src/restricted_token_utils.cc:88: if (base::win::GetVersion() >=
base::win::VERSION_VISTA) {
Nit: Remove {}?

http://codereview.chromium.org/3823002/diff/12004/81063
File views/controls/menu/menu_host_win.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81063#newcode1
views/controls/menu/menu_host_win.cc:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
Nit: 2010

[brettw, 2010-10-14 20:19:55]

New snap up

http://codereview.chromium.org/3823002/diff/12004/81017
File base/win_util.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81017#newcode8
base/win_util.cc:8: #include <shobjidl.h>  // Must be before propkey.
On 2010/10/14 19:53:38, Peter Kasting wrote:
> Did you mean for these changes and all the code deletions to be in here?

This is the part of the change described by "Replace the AppUserModel property
key..." There were also a few unused functions.

http://codereview.chromium.org/3823002/diff/12004/81056
File ipc/ipc_channel_win.cc (right):

http://codereview.chromium.org/3823002/diff/12004/81056#newcode22
ipc/ipc_channel_win.cc:22: namespace {
On 2010/10/14 19:53:38, Peter Kasting wrote:
> Did you mean for these changes to be in this patch?

Yes, I moved this function from win_util, but I forgot to mention this in the
description. I added it.

[Peter Kasting, 2010-10-14 20:30:45]

LGTM; only three comments from the first review that you didn't address, I've
copied them below.

http://codereview.chromium.org/3823002/diff/47008/20033
File chrome/browser/google/google_update.cc (right):

http://codereview.chromium.org/3823002/diff/47008/20033#newcode1
chrome/browser/google/google_update.cc:1: // Copyright (c) 2006-2008 The
Chromium Authors. All rights reserved.
Nit: 2010

http://codereview.chromium.org/3823002/diff/47008/20036
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/3823002/diff/47008/20036#newcode1326
chrome/browser/renderer_host/render_widget_host_view_win.cc:1326: DLOG(ERROR) <<
"KeyEvent " << message << " wParam " << wparam;
Did you mean to leave this in?

http://codereview.chromium.org/3823002/diff/47008/20063
File sandbox/src/policy_target_test.cc (right):

http://codereview.chromium.org/3823002/diff/47008/20063#newcode1
sandbox/src/policy_target_test.cc:1: // Copyright (c) 2006-2010 The Chromium
Authors. All rights reserved.
Nit: Remove 2006

[brettw, 2010-10-14 20:36:40]

http://codereview.chromium.org/3823002/diff/47008/20036
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/3823002/diff/47008/20036#newcode1326
chrome/browser/renderer_host/render_widget_host_view_win.cc:1326: DLOG(ERROR) <<
"KeyEvent " << message << " wParam " << wparam;
Whoops! Thanks.