Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: base/path_service_unittest.cc

Issue 3823002: Move windows version-related stuff out of base/win_util and into base/win/win... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/path_service.h" 5 #include "base/path_service.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #if defined(OS_WIN) 10 #if defined(OS_WIN)
11 #include "base/win_util.h" 11 #include "base/win/windows_version.h"
12 #endif 12 #endif
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "testing/gtest/include/gtest/gtest-spi.h" 14 #include "testing/gtest/include/gtest/gtest-spi.h"
15 #include "testing/platform_test.h" 15 #include "testing/platform_test.h"
16 16
17 namespace { 17 namespace {
18 18
19 // Returns true if PathService::Get returns true and sets the path parameter 19 // Returns true if PathService::Get returns true and sets the path parameter
20 // to non-empty for the given PathService::DirType enumeration value. 20 // to non-empty for the given PathService::DirType enumeration value.
21 bool ReturnsValidPath(int dir_type) { 21 bool ReturnsValidPath(int dir_type) {
(...skipping 21 matching lines...) Expand all
43 // in the development environment. (This test was created because a few 43 // in the development environment. (This test was created because a few
44 // later changes to Get broke the semantics of the function and yielded the 44 // later changes to Get broke the semantics of the function and yielded the
45 // correct value while returning false.) 45 // correct value while returning false.)
46 TEST_F(PathServiceTest, Get) { 46 TEST_F(PathServiceTest, Get) {
47 for (int key = base::DIR_CURRENT; key < base::PATH_END; ++key) { 47 for (int key = base::DIR_CURRENT; key < base::PATH_END; ++key) {
48 EXPECT_PRED1(ReturnsValidPath, key); 48 EXPECT_PRED1(ReturnsValidPath, key);
49 } 49 }
50 #if defined(OS_WIN) 50 #if defined(OS_WIN)
51 for (int key = base::PATH_WIN_START + 1; key < base::PATH_WIN_END; ++key) { 51 for (int key = base::PATH_WIN_START + 1; key < base::PATH_WIN_END; ++key) {
52 if (key == base::DIR_LOCAL_APP_DATA_LOW && 52 if (key == base::DIR_LOCAL_APP_DATA_LOW &&
53 win_util::GetWinVersion() < win_util::WINVERSION_VISTA) { 53 base::win::GetVersion() < base::win::VERSION_VISTA) {
54 // DIR_LOCAL_APP_DATA_LOW is not supported prior Vista and is expected to 54 // DIR_LOCAL_APP_DATA_LOW is not supported prior Vista and is expected to
55 // fail. 55 // fail.
56 EXPECT_TRUE(ReturnsInvalidPath(key)) << key; 56 EXPECT_TRUE(ReturnsInvalidPath(key)) << key;
57 } else { 57 } else {
58 EXPECT_TRUE(ReturnsValidPath(key)) << key; 58 EXPECT_TRUE(ReturnsValidPath(key)) << key;
59 } 59 }
60 } 60 }
61 #elif defined(OS_MACOSX) 61 #elif defined(OS_MACOSX)
62 for (int key = base::PATH_MAC_START + 1; key < base::PATH_MAC_END; ++key) { 62 for (int key = base::PATH_MAC_START + 1; key < base::PATH_MAC_END; ++key) {
63 EXPECT_PRED1(ReturnsValidPath, key); 63 EXPECT_PRED1(ReturnsValidPath, key);
64 } 64 }
65 #endif 65 #endif
66 } 66 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698