Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: chrome/browser/bug_report_util.h

Issue 3823002: Move windows version-related stuff out of base/win_util and into base/win/win... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BUG_REPORT_UTIL_H_ 5 #ifndef CHROME_BROWSER_BUG_REPORT_UTIL_H_
6 #define CHROME_BROWSER_BUG_REPORT_UTIL_H_ 6 #define CHROME_BROWSER_BUG_REPORT_UTIL_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #if defined(OS_MACOSX) 12 #if defined(OS_MACOSX)
13 #include "base/mac_util.h" 13 #include "base/mac_util.h"
14 #include "base/sys_info.h" 14 #include "base/sys_info.h"
15 #elif defined(OS_WIN)
16 #include "base/win/windows_version.h"
15 #endif 17 #endif
16 #include "chrome/browser/userfeedback/proto/common.pb.h" 18 #include "chrome/browser/userfeedback/proto/common.pb.h"
17 #include "chrome/browser/userfeedback/proto/extension.pb.h" 19 #include "chrome/browser/userfeedback/proto/extension.pb.h"
18 #include "chrome/browser/userfeedback/proto/math.pb.h" 20 #include "chrome/browser/userfeedback/proto/math.pb.h"
19 #include "gfx/rect.h" 21 #include "gfx/rect.h"
20 22
21 #if defined(OS_CHROMEOS) 23 #if defined(OS_CHROMEOS)
22 #include "chrome/browser/chromeos/cros/syslogs_library.h" 24 #include "chrome/browser/chromeos/cros/syslogs_library.h"
23 #include "chrome/browser/chromeos/cros/cros_library.h" 25 #include "chrome/browser/chromeos/cros/cros_library.h"
24 #endif 26 #endif
(...skipping 22 matching lines...) Expand all
47 CANT_SIGN_IN, 49 CANT_SIGN_IN,
48 CHROME_MISBEHAVES, 50 CHROME_MISBEHAVES,
49 SOMETHING_MISSING, 51 SOMETHING_MISSING,
50 BROWSER_CRASH, 52 BROWSER_CRASH,
51 OTHER_PROBLEM 53 OTHER_PROBLEM
52 }; 54 };
53 #endif 55 #endif
54 56
55 // SetOSVersion copies the maj.minor.build + servicePack_string 57 // SetOSVersion copies the maj.minor.build + servicePack_string
56 // into a string. We currently have: 58 // into a string. We currently have:
57 // win_util::GetWinVersion returns WinVersion, which is just 59 // base::win::GetVersion returns WinVersion, which is just
58 // an enum of 2000, XP, 2003, or VISTA. Not enough detail for 60 // an enum of 2000, XP, 2003, or VISTA. Not enough detail for
59 // bug reports. 61 // bug reports.
60 // base::SysInfo::OperatingSystemVersion returns an std::string 62 // base::SysInfo::OperatingSystemVersion returns an std::string
61 // but doesn't include the build or service pack. That function 63 // but doesn't include the build or service pack. That function
62 // is probably the right one to extend, but will require changing 64 // is probably the right one to extend, but will require changing
63 // all the call sites or making it a wrapper around another util. 65 // all the call sites or making it a wrapper around another util.
64 static void SetOSVersion(std::string *os_version); 66 static void SetOSVersion(std::string *os_version);
65 67
66 // This sets the address of the feedback server to be used by SendReport 68 // This sets the address of the feedback server to be used by SendReport
67 static void SetFeedbackServer(const std::string& server); 69 static void SetFeedbackServer(const std::string& server);
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 #if defined(OS_CHROMEOS) 102 #if defined(OS_CHROMEOS)
101 static bool ValidFeedbackSize(const std::string& content); 103 static bool ValidFeedbackSize(const std::string& content);
102 #endif 104 #endif
103 105
104 static std::string feedback_server_; 106 static std::string feedback_server_;
105 107
106 DISALLOW_IMPLICIT_CONSTRUCTORS(BugReportUtil); 108 DISALLOW_IMPLICIT_CONSTRUCTORS(BugReportUtil);
107 }; 109 };
108 110
109 #endif // CHROME_BROWSER_BUG_REPORT_UTIL_H_ 111 #endif // CHROME_BROWSER_BUG_REPORT_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698