Issue 3798001: Merge 62408 - Fixes bugs in usage of adding a new tab with a disposition of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3798001: Merge 62408 - Fixes bugs in usage of adding a new tab with a disposition of... (Closed)

Created:
10 years, 2 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/552/src/

Visibility:
Public.

Merge 62408 - Fixes bugs in usage of adding a new tab with a disposition of NEW_WINDOW. Many places were leaking a Browser and preventing Chrome from shutting down. BUG=59058 TEST=none Review URL: http://codereview.chromium.org/3655006 TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62417

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -77 lines)			Patch
M	chrome/browser/cocoa/about_window_controller.mm	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.mm	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	chrome/browser/gtk/options/advanced_contents_gtk.cc	View	8 chunks	+16 lines, -18 lines	0 comments	Download
M	chrome/browser/gtk/options/content_filter_page_gtk.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/gtk/options/cookie_filter_page_gtk.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
A +	chrome/browser/show_options_url.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/show_options_url.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/views/options/advanced_contents_view.cc	View	4 chunks	+11 lines, -15 lines	0 comments	Download
M	chrome/browser/views/options/cookie_filter_page_view.cc	View	2 chunks	+3 lines, -8 lines	0 comments	Download
M	chrome/browser/views/options/general_page_view.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/views/options/plugin_filter_page_view.cc	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)