chrome/browser/views/options/plugin_filter_page_view.cc - Issue 3798001: Merge 62408 - Fixes bugs in usage of adding a new tab with a disposition of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/options/plugin_filter_page_view.cc

Issue 3798001: Merge 62408 - Fixes bugs in usage of adding a new tab with a disposition of... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/552/src/

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/views/options/plugin_filter_page_view.cc

===================================================================

--- chrome/browser/views/options/plugin_filter_page_view.cc (revision 62416)

+++ chrome/browser/views/options/plugin_filter_page_view.cc (working copy)

@@ -6,7 +6,7 @@

#include "app/l10n_util.h"

#include "chrome/browser/browser.h"

-#include "chrome/browser/browser_window.h"

+#include "chrome/browser/show_options_url.h"

#include "chrome/common/url_constants.h"

#include "grit/generated_resources.h"

#include "views/grid_layout.h"

@@ -45,10 +45,5 @@

void PluginFilterPageView::LinkActivated(views::Link* source,

int event_flags) {

- // We open a new browser window so the Options dialog doesn't get lost

- // behind other windows.

- Browser* browser = Browser::Create(profile());

- browser->OpenURL(GURL(chrome::kChromeUIPluginsURL), GURL(),

- NEW_FOREGROUND_TAB, PageTransition::LINK);

- browser->window()->Show();

+ browser::ShowOptionsURL(profile(), GURL(chrome::kChromeUIPluginsURL));

}

« no previous file with comments | « chrome/browser/views/options/general_page_view.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »