Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 3785008: AU: Don't send no-op operations in the delta payload. (Closed)

Created:
10 years, 2 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Visibility:
Public.

Description

AU: Don't send no-op operations in the delta payload. This reduces the payload a bit and also speeds up updates on the client by reducing the I/O. This CL also removes a somewhat broken check for written blocks. It seems that the intent of the check was to make sure each block is updated with some data but since some file data blocks may be used as scratch the check is somewhat meaningless. The CL removes the check because some blocks may never be written if they were a part of a no-op operation. BUG=7543 TEST=unit tests, generated a no-op delta an installed on the device Change-Id: I31f388651a45d10dd931389a6c80ac18cb10f466 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9fa7ec5

Patch Set 1 #

Patch Set 2 : fix bugs, add more unit tests #

Patch Set 3 : simplify the code -- slower but it runs on the server anyway #

Patch Set 4 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -52 lines) Patch
M delta_diff_generator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M delta_diff_generator.cc View 1 2 9 chunks +47 lines, -37 lines 0 comments Download
M delta_diff_generator_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M delta_performer.cc View 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M delta_performer_unittest.cc View 8 chunks +28 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
petkov
10 years, 2 months ago (2010-10-14 23:34:16 UTC) #1
petkov
PTAL -- fixed bugs, added unit tests, retested
10 years, 2 months ago (2010-10-15 18:00:43 UTC) #2
adlr
10 years, 2 months ago (2010-10-18 17:32:28 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698