Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: delta_diff_generator.h

Issue 3785008: AU: Don't send no-op operations in the delta payload. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git
Patch Set: fix comment Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | delta_diff_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: delta_diff_generator.h
diff --git a/delta_diff_generator.h b/delta_diff_generator.h
index de3be0da0494e89c1fd46ecc678a03e86d516b1f..9fbe0a55cc1e7314c6b67276678af5ccf2bc6139 100644
--- a/delta_diff_generator.h
+++ b/delta_diff_generator.h
@@ -211,6 +211,10 @@ class DeltaDiffGenerator {
std::vector<DeltaArchiveManifest_InstallOperation>* kernel_ops,
std::vector<Vertex::Index>* final_order);
+ // Returns true if |op| is a no-op operation that doesn't do any useful work
+ // (e.g., a move operation that copies blocks onto themselves).
+ static bool IsNoopOperation(const DeltaArchiveManifest_InstallOperation& op);
+
private:
// This should never be constructed
DISALLOW_IMPLICIT_CONSTRUCTORS(DeltaDiffGenerator);
« no previous file with comments | « no previous file | delta_diff_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698