Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: delta_diff_generator.h

Issue 3785008: AU: Don't send no-op operations in the delta payload. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git
Patch Set: fix comment Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | delta_diff_generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_PLATFORM_UPDATE_ENGINE_DELTA_DIFF_GENERATOR_H__ 5 #ifndef CHROMEOS_PLATFORM_UPDATE_ENGINE_DELTA_DIFF_GENERATOR_H__
6 #define CHROMEOS_PLATFORM_UPDATE_ENGINE_DELTA_DIFF_GENERATOR_H__ 6 #define CHROMEOS_PLATFORM_UPDATE_ENGINE_DELTA_DIFF_GENERATOR_H__
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 Graph* graph, 204 Graph* graph,
205 const std::string& new_kernel_part, 205 const std::string& new_kernel_part,
206 const std::string& new_image, 206 const std::string& new_image,
207 off_t image_size, 207 off_t image_size,
208 int fd, 208 int fd,
209 off_t* data_file_size, 209 off_t* data_file_size,
210 off_t chunk_size, 210 off_t chunk_size,
211 std::vector<DeltaArchiveManifest_InstallOperation>* kernel_ops, 211 std::vector<DeltaArchiveManifest_InstallOperation>* kernel_ops,
212 std::vector<Vertex::Index>* final_order); 212 std::vector<Vertex::Index>* final_order);
213 213
214 // Returns true if |op| is a no-op operation that doesn't do any useful work
215 // (e.g., a move operation that copies blocks onto themselves).
216 static bool IsNoopOperation(const DeltaArchiveManifest_InstallOperation& op);
217
214 private: 218 private:
215 // This should never be constructed 219 // This should never be constructed
216 DISALLOW_IMPLICIT_CONSTRUCTORS(DeltaDiffGenerator); 220 DISALLOW_IMPLICIT_CONSTRUCTORS(DeltaDiffGenerator);
217 }; 221 };
218 222
219 extern const char* const kBsdiffPath; 223 extern const char* const kBsdiffPath;
220 extern const char* const kBspatchPath; 224 extern const char* const kBspatchPath;
221 extern const char* const kDeltaMagic; 225 extern const char* const kDeltaMagic;
222 226
223 }; // namespace chromeos_update_engine 227 }; // namespace chromeos_update_engine
224 228
225 #endif // CHROMEOS_PLATFORM_UPDATE_ENGINE_DELTA_DIFF_GENERATOR_H__ 229 #endif // CHROMEOS_PLATFORM_UPDATE_ENGINE_DELTA_DIFF_GENERATOR_H__
OLDNEW
« no previous file with comments | « no previous file | delta_diff_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698