Issue 3759004: ipc_channel: warn if someone forgets to check the result of Connect()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3759004: ipc_channel: warn if someone forgets to check the result of Connect() (Closed)

Created:
10 years, 2 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, jam, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

ipc_channel: warn if someone forgets to check the result of Connect() I found a test that was doing this. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63083

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -9 lines)			Patch
M	chrome/renderer/renderer_main_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_channel.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	ipc/ipc_fuzzing_tests.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_send_fds_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_tests.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm