ipc/ipc_send_fds_test.cc - Issue 3759004: ipc_channel: warn if someone forgets to check the result of Connect()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_send_fds_test.cc

Issue 3759004: ipc_channel: warn if someone forgets to check the result of Connect() (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: fixes Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_send_fds_test.cc

diff --git a/ipc/ipc_send_fds_test.cc b/ipc/ipc_send_fds_test.cc

index e1f19dcf3b0849bf676cb3f77e61f69ad3f910ee..b49f77338a0ddbb0c0299abbf4800d2ba0e10397 100644

--- a/ipc/ipc_send_fds_test.cc

+++ b/ipc/ipc_send_fds_test.cc

@@ -110,7 +110,7 @@ int TestDescriptorClient(ino_t expected_inode_num) {

// Setup IPC channel.

IPC::Channel chan(kTestClientChannel, IPC::Channel::MODE_CLIENT,

&listener);

- chan.Connect();

+ ASSERT_TRUE(chan.Connect());

MessageLoop::current()->Run();

return 0;

« no previous file with comments | « ipc/ipc_fuzzing_tests.cc ('k') | ipc/ipc_tests.cc » ('j') | no next file with comments »