chrome/renderer/renderer_main_unittest.cc - Issue 3759004: ipc_channel: warn if someone forgets to check the result of Connect()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/renderer_main_unittest.cc

Issue 3759004: ipc_channel: warn if someone forgets to check the result of Connect() (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: fixes Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/renderer_main_unittest.cc

diff --git a/chrome/renderer/renderer_main_unittest.cc b/chrome/renderer/renderer_main_unittest.cc

index f30103c59912db70203acf92d06a195acc0abfef..995050f5d85cf5a933159d5fab030e655a5c3935 100644

--- a/chrome/renderer/renderer_main_unittest.cc

+++ b/chrome/renderer/renderer_main_unittest.cc

@@ -92,7 +92,7 @@ TEST_F(RendererMainTest, CreateDestroy) {

base::ProcessHandle renderer_pid = SpawnChild("SimpleRenderer",

&control_channel);

- control_channel.Connect();

+ ASSERT_TRUE(control_channel.Connect());

MessageLoop::current()->Run();

// The renderer should exit when we close the channel.

« no previous file with comments | « no previous file | ipc/ipc_channel.h » ('j') | no next file with comments »