Issue 3702006: Ditch COMPLETION_FAILED; it didn't make any UI difference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3702006: Ditch COMPLETION_FAILED; it didn't make any UI difference (Closed)

Created:
10 years, 2 months ago by rochberg

Modified:
9 years, 7 months ago

Reviewers:
Eric Shienbrood

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/modemmanager.git

Visibility:
Public.

Description

Ditch COMPLETION_FAILED; it didn't make any UI difference BUG=6885 TEST=Build cromo Change-Id: I05fb47b177bdf03a49ca32a5766c3ec79790ab24 Replace ActivationCompleted with ActivationStateChanged Add error returns enum BUG=6885 TEST=mm-modem.h is correct, cromo compiles Change-Id: I2b6a49bda5a6ff7bf6e4aac2e99914bf3c33c732 Review URL: http://codereview.chromium.org/3705001 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=00882d8

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -14 lines)			Patch
	M	introspection/mm-modem-cdma.xml	View		6 chunks	+78 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages