Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: introspection/mm-modem-cdma.xml

Issue 3702006: Ditch COMPLETION_FAILED; it didn't make any UI difference (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/modemmanager.git
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: introspection/mm-modem-cdma.xml
diff --git a/introspection/mm-modem-cdma.xml b/introspection/mm-modem-cdma.xml
index 2c7ca3c005e3298d1a10ab4a9621b5a63b8bba07..6859f4f6c98c8c2f3157462aa7123989ec73871a 100644
--- a/introspection/mm-modem-cdma.xml
+++ b/introspection/mm-modem-cdma.xml
@@ -5,7 +5,9 @@
<method name="Activate">
<tp:docstring>
- Activates the modem for use with a given carrier.
+ Activates the modem for use with a given carrier. In the
+ event of immediate failure, returns an error value instead of
+ setting a DBus error.
</tp:docstring>
<annotation name="org.freedesktop.DBus.GLib.Async" value=""/>
<annotation name="org.freedesktop.DBus.GLib.CSymbol" value="impl_modem_cdma_activate"/>
@@ -14,6 +16,13 @@
Name of carrier.
</tp:docstring>
</arg>
+ <arg name="immediate_error" type="u" direction="out">
+ <tp:docstring>
+ An enum from MM_MODEM_CDMA_ACTIVATION_ERROR. This is
+ returned for immediate errors. Delayed errors are returned
+ via an ActivationStateChanged signal
+ </tp:docstring>
+ </arg>
</method>
<method name="ActivateManual">
@@ -32,7 +41,7 @@
</method>
<method name="ActivateManualDebug">
- <tp:docstring>
+ <tp:docstring>
Workaround for the fact that dbus-send cannot send
dictionaries of variants. Calls ActivateManual, with
system_id converted to int.
@@ -46,6 +55,24 @@
</arg>
</method>
+ <signal name="ActivationStateChanged">
+ <tp:docstring>
+ The device activation state changed.
+ </tp:docstring>
+ <arg name="activation_state" type="u" tp:type="MM_MODEM_CDMA_ACTIVATION_STATE">
+ <tp:docstring>Current activation state</tp:docstring>
+ </arg>
+ <arg name="activation_error" type="u" tp:type="MM_MODEM_CDMA_ACTIVATION_ERROR">
+ <tp:docstring>Carrier-specific error code</tp:docstring>
+ </arg>
+ <arg name="status_changes" type="a{sv}">
+ <tp:docstring>Selected Modem.Simple.GetStatus keys that have changed as a
+ result of this activation state change. Will include 'mdn'
+ and 'min'.
+ </tp:docstring>
+ </arg>
+ </signal>
+
<method name="GetSignalQuality">
<tp:docstring>
Get the current signal quality.
@@ -96,17 +123,6 @@
</arg>
</signal>
- <signal name="ActivationCompleted">
- <tp:docstring>
- Send a notification that activation of the modem has completed.
- </tp:docstring>
- <arg name="activated" type="b">
- <tp:docstring>
- True if succeeded, false if failed.
- </tp:docstring>
- </arg>
- </signal>
-
<method name="GetRegistrationState">
<tp:docstring>Get device registration state.</tp:docstring>
<annotation name="org.freedesktop.DBus.GLib.Async" value=""/>
@@ -166,6 +182,54 @@
<tp:docstring>Device is ready for use.</tp:docstring>
</tp:enumvalue>
</tp:enum>
+
+ <tp:enum name="MM_MODEM_CDMA_ACTIVATION_ERROR" type="u">
+ <tp:enumvalue suffix="NO_ERROR" value="0"/>
+ <tp:enumvalue suffix="ROAMING" value="1">
+ <tp:docstring>
+ Device cannot activate while roaming.
+ </tp:docstring>
+ </tp:enumvalue>
+ <tp:enumvalue suffix="WRONG_RADIO_INTERFACE" value="2">
+ <tp:docstring>
+ Device cannot activate on this network type (eg EVDO vs 1xRTT).
+ </tp:docstring>
+ </tp:enumvalue>
+ <tp:enumvalue suffix="COULD_NOT_CONNECT" value="3">
+ <tp:docstring>
+ Device could not connect to the network for activation.
+ </tp:docstring>
+ </tp:enumvalue>
+ <tp:enumvalue suffix="SECURITY_AUTHENTICATION_FAILED" value="4">
+ <tp:docstring>
+ Device could not authenticate to the network for activation.
+ </tp:docstring>
+ </tp:enumvalue>
+ <tp:enumvalue suffix="PROVISIONING_FAILED" value="5">
+ <tp:docstring>
+ Later stages of device provisioning failed.
+ </tp:docstring>
+ </tp:enumvalue>
+ <tp:enumvalue suffix="NO_SIGNAL" value="6">
+ <tp:docstring>
+ No signal available.
+ </tp:docstring>
+ </tp:enumvalue>
+ <tp:enumvalue suffix="UNKNOWN" value="7">
+ <tp:docstring>
+ An error occurred.
+ </tp:docstring>
+ </tp:enumvalue>
+ <tp:enumvalue suffix="TIMED_OUT" value="8">
+ <tp:docstring>
+ Activation timed out.
+ </tp:docstring>
+ </tp:enumvalue>
+ <tp:enumvalue suffix="START_FAILED" value="9">
+ <tp:docstring>
+ API call for initial activation failed.
+ </tp:docstring>
+ </tp:enumvalue>
+ </tp:enum>
</interface>
</node>
-
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698