Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 3705001: Replace ActivationCompleted with ActivationStateChanged Add error returns enum (Closed)

Created:
10 years, 2 months ago by rochberg
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Replace ActivationCompleted with ActivationStateChanged Add error returns enum BUG=6885 TEST=mm-modem.h is correct, cromo compiles Change-Id: I2b6a49bda5a6ff7bf6e4aac2e99914bf3c33c732 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=1a0db62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -14 lines) Patch
M introspection/mm-modem-cdma.xml View 6 chunks +83 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rochberg
10 years, 2 months ago (2010-10-11 00:57:03 UTC) #1
Eric Shienbrood
LGTM
10 years, 2 months ago (2010-10-11 04:19:17 UTC) #2
Jason Glasgow
10 years, 2 months ago (2010-10-11 13:54:55 UTC) #3
LGTM in case you were waiting for me.

Powered by Google App Engine
This is Rietveld 408576698