Issue 3672003: fix bookmarks API crash when handling invalid URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3672003: fix bookmarks API crash when handling invalid URL (Closed)

Created:
10 years, 2 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org

Visibility:
Public.

Description

fix bookmarks API crash when handling invalid URL also re-enable test on Windows (can't repro crashes) BUG=56945, 45595 TEST=ExtensionApiTest.Bookmarks Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62170

Patch Set 1 #

Patch Set 2 : whitespace #

Patch Set 3 : more whitespace #

Total comments: 1

Patch Set 4 : missing semicolon #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -23 lines)			Patch
M	chrome/browser/extensions/extension_bookmarks_apitest.cc	View		1 chunk	+1 line, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module.cc	View		1 chunk	+8 lines, -11 lines	0 comments	Download
M	chrome/renderer/resources/extension_apitest.js	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/bookmarks/test.js	View	1 2 3	2 chunks	+24 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

10 years, 2 months ago (2010-10-11 17:36:43 UTC) #2

lgtm

http://codereview.chromium.org/3672003/diff/4001/5004
File chrome/test/data/extensions/api_test/bookmarks/test.js (right):

http://codereview.chromium.org/3672003/diff/4001/5004#newcode286
chrome/test/data/extensions/api_test/bookmarks/test.js:286: var url =
"http://example.com/hello"
While you're in here, how about adding a semicolon at the end of this line.
Thank you, javascript designers, for making this optional :(

Expand Messages | Collapse Messages