chrome/browser/extensions/extension_bookmarks_apitest.cc - Issue 3672003: fix bookmarks API crash when handling invalid URL

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_bookmarks_apitest.cc

Issue 3672003: fix bookmarks API crash when handling invalid URL (Closed)

Patch Set: missing semicolon Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/extension_apitest.h"	5 #include "chrome/browser/extensions/extension_apitest.h"

6	6

7 #if defined(OS_WIN)	7 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Bookmarks) {

8 // On Windows, this test occasionally crash. See http://crbug.com/45595

9 #define MAYBE_Bookmarks DISABLED_Bookmarks

10 #else

11 #define MAYBE_Bookmarks Bookmarks

12 #endif

13

14 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Bookmarks) {

15 ASSERT_TRUE(RunExtensionTest("bookmarks")) << message_;	8 ASSERT_TRUE(RunExtensionTest("bookmarks")) << message_;

16 }	9 }

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_bookmarks_module.cc » ('j') | no next file with comments »