Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3107)

Unified Diff: chrome/renderer/resources/extension_apitest.js

Issue 3672003: fix bookmarks API crash when handling invalid URL (Closed)
Patch Set: missing semicolon Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extension_apitest.js
diff --git a/chrome/renderer/resources/extension_apitest.js b/chrome/renderer/resources/extension_apitest.js
index ca7a4df4061dd6def887e843fe5ee98442140df9..4b6f939586916aa5182f75c38b87e7f423533bfe 100644
--- a/chrome/renderer/resources/extension_apitest.js
+++ b/chrome/renderer/resources/extension_apitest.js
@@ -173,6 +173,8 @@ var chrome = chrome || {};
chrome.test.assertNoLastError();
} else {
chrome.test.assertEq(typeof(expectedError), 'string');
+ chrome.test.assertTrue(chrome.extension.lastError != undefined,
+ "No lastError, but expected " + expectedError);
chrome.test.assertEq(expectedError, chrome.extension.lastError.message);
}
@@ -214,8 +216,8 @@ var chrome = chrome || {};
return chrome.test.callback(func);
};
- chrome.test.callbackFail = function(expectedError) {
- return chrome.test.callback(null, expectedError);
+ chrome.test.callbackFail = function(expectedError, func) {
+ return chrome.test.callback(func, expectedError);
};
chrome.test.runTests = function(tests) {
« no previous file with comments | « chrome/browser/extensions/extension_bookmarks_module.cc ('k') | chrome/test/data/extensions/api_test/bookmarks/test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698