Issue 365008: Grouping the extensions and calling out the disabled ones more prominently

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 365008: Grouping the extensions and calling out the disabled ones more prominently (Closed)

Created:
11 years, 1 month ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
rafaelw

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Grouping the extensions and calling out the disabled ones more prominently. Also added an unused string for 'getting more extensions', so we can translate. Converted 'Developer Tools' references to 'Developer Mode', to avoid confusion with Chrome's developer tools. TEST=Load extension b_foo through --load-extension. Open chrome://extensions/ and notice extension b_foo is on top, even though another extension a_foo normally would appear at the top due to alphabetical sorting. Then disable an extension and notice it should turn all gray. Enable, and it should no longer be gray. BUG=http://crbug.com/26699, http://crbug.com/25850 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31021

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -51 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	3 chunks	+12 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.cc	View		3 chunks	+14 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/extensions_ui.html	View		14 chunks	+59 lines, -41 lines	1 comment	Download
A	chrome/browser/resources/gray.png	View	1	Binary file		0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rafaelw

11 years, 1 month ago (2009-11-04 22:24:40 UTC) #2

lgtm.

http://codereview.chromium.org/365008/diff/2001/3003
File chrome/browser/resources/extensions_ui.html (right):

http://codereview.chromium.org/365008/diff/2001/3003#newcode642
Line 642: <tr jsvalues=".className:'extension_enabled_' + enabled">
nit: what happened to: enabled ? 'extension_enabled' : 'extension_disabled'.

Expand Messages | Collapse Messages