Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: chrome/browser/extensions/extensions_ui.cc

Issue 365008: Grouping the extensions and calling out the disabled ones more prominently (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_ui.cc
===================================================================
--- chrome/browser/extensions/extensions_ui.cc (revision 30835)
+++ chrome/browser/extensions/extensions_ui.cc (working copy)
@@ -52,10 +52,10 @@
DictionaryValue localized_strings;
localized_strings.SetString(L"title",
l10n_util::GetString(IDS_EXTENSIONS_TITLE));
- localized_strings.SetString(L"devToolsLink",
- l10n_util::GetString(IDS_EXTENSIONS_DEVELOPER_TOOLS_LINK));
- localized_strings.SetString(L"devToolsPrefix",
- l10n_util::GetString(IDS_EXTENSIONS_DEVELOPER_TOOLS_PREFIX));
+ localized_strings.SetString(L"devModeLink",
+ l10n_util::GetString(IDS_EXTENSIONS_DEVELOPER_MODE_LINK));
+ localized_strings.SetString(L"devModePrefix",
+ l10n_util::GetString(IDS_EXTENSIONS_DEVELOPER_MODE_PREFIX));
localized_strings.SetString(L"loadUnpackedButton",
l10n_util::GetString(IDS_EXTENSIONS_LOAD_UNPACKED_BUTTON));
localized_strings.SetString(L"packButton",
@@ -66,6 +66,8 @@
l10n_util::GetString(IDS_EXTENSIONS_NONE_INSTALLED));
localized_strings.SetString(L"extensionDisabled",
l10n_util::GetString(IDS_EXTENSIONS_DISABLED_EXTENSION));
+ localized_strings.SetString(L"inDevelopment",
+ l10n_util::GetString(IDS_EXTENSIONS_IN_DEVELOPMENT));
localized_strings.SetString(L"extensionId",
l10n_util::GetString(IDS_EXTENSIONS_ID));
localized_strings.SetString(L"extensionVersion",
@@ -468,6 +470,14 @@
extension_data->SetString(L"description", extension->description());
extension_data->SetString(L"version", extension->version()->GetString());
extension_data->SetBoolean(L"enabled", enabled);
+
+ // Determine the sort order: Extensions loaded through --load-extensions show
+ // up at the top. Disabled extensions show up at the bottom.
+ if (extension->location() == Extension::LOAD)
+ extension_data->SetInteger(L"order", 1);
+ else
+ extension_data->SetInteger(L"order", 2);
+
if (!extension->options_url().is_empty())
extension_data->SetString(L"options_url", extension->options_url().spec());

Powered by Google App Engine
This is Rietveld 408576698