Autofill help link should link to locale specific site

Autofill help link should link to locale specific site

Changes Autofill help link to be .grd based for all platforms.  Also, unified the handling of activating the link.

BUG=57092
TEST=Manual tests from prefs dialog and credit card infobar.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62058

[James Hawkins, 2010-10-09 00:22:52]

Looks like you forgot to finish the CL message.

http://codereview.chromium.org/3645002/diff/1/4
File chrome/browser/autofill/autofill_dialog_gtk.cc (right):

http://codereview.chromium.org/3645002/diff/1/4#newcode369
chrome/browser/autofill/autofill_dialog_gtk.cc:369: if (!browser ||
!browser->GetSelectedTabContents())
You DCHECK in the InfoBar code, yet check for |browser| here. Can the dialog be
open yet the browser is closed?

[dhollowa, 2010-10-09 00:32:07]

http://codereview.chromium.org/3645002/diff/1/4
File chrome/browser/autofill/autofill_dialog_gtk.cc (right):

http://codereview.chromium.org/3645002/diff/1/4#newcode369
chrome/browser/autofill/autofill_dialog_gtk.cc:369: if (!browser ||
!browser->GetSelectedTabContents())
On 2010/10/09 00:22:52, James Hawkins wrote:
> You DCHECK in the InfoBar code, yet check for |browser| here. Can the dialog
be
> open yet the browser is closed?

Yes.  I believe so.

[James Hawkins, 2010-10-09 00:47:36]

http://codereview.chromium.org/3645002/diff/1/4
File chrome/browser/autofill/autofill_dialog_gtk.cc (right):

http://codereview.chromium.org/3645002/diff/1/4#newcode369
chrome/browser/autofill/autofill_dialog_gtk.cc:369: if (!browser ||
!browser->GetSelectedTabContents())
On 2010/10/09 00:32:07, dhollowa wrote:
> On 2010/10/09 00:22:52, James Hawkins wrote:
> > You DCHECK in the InfoBar code, yet check for |browser| here. Can the dialog
> be
> > open yet the browser is closed?
> 
> Yes.  I believe so.
> 
> 

Under what circumstances?

[dhollowa, 2010-10-09 00:56:31]

On 2010/10/09 00:47:36, James Hawkins wrote:
> http://codereview.chromium.org/3645002/diff/1/4
> File chrome/browser/autofill/autofill_dialog_gtk.cc (right):
> 
> http://codereview.chromium.org/3645002/diff/1/4#newcode369
> chrome/browser/autofill/autofill_dialog_gtk.cc:369: if (!browser ||
> !browser->GetSelectedTabContents())
> On 2010/10/09 00:32:07, dhollowa wrote:
> > On 2010/10/09 00:22:52, James Hawkins wrote:
> > > You DCHECK in the InfoBar code, yet check for |browser| here. Can the
dialog
> > be
> > > open yet the browser is closed?
> > 
> > Yes.  I believe so.
> > 
> > 
> 
> Under what circumstances?

I'd need to verify on Linux, but on Mac it is quite simple to open the Autofill
dialog and then close all open browser windows.  Then click the link on the
Autofill dialog.

[dhollowa, 2010-10-09 01:08:21]

http://codereview.chromium.org/3645002/diff/1/4
File chrome/browser/autofill/autofill_dialog_gtk.cc (right):

http://codereview.chromium.org/3645002/diff/1/4#newcode369
chrome/browser/autofill/autofill_dialog_gtk.cc:369: if (!browser ||
!browser->GetSelectedTabContents())
On 2010/10/09 00:47:36, James Hawkins wrote:
> On 2010/10/09 00:32:07, dhollowa wrote:
> > On 2010/10/09 00:22:52, James Hawkins wrote:
> > > You DCHECK in the InfoBar code, yet check for |browser| here. Can the
dialog
> > be
> > > open yet the browser is closed?
> > 
> > Yes.  I believe so.
> > 
> > 
> 
> Under what circumstances?

[Associating reply... got move to top-level somehow].

I'd need to verify on Linux, but on Mac it is quite simple to open the Autofill
dialog and then close all open browser windows.  Then click the link on the
Autofill dialog.

[James Hawkins, 2010-10-09 01:14:03]

LGTM