Autofill help link should link to locale specific site

chrome/browser/autofill/autofill_dialog_gtk.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_dialog.h"
 
 #include <gtk/gtk.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 348 matching lines @@
   }
   gboolean is_header;
   gboolean is_separator;
   gtk_tree_model_get(model, &iter, COL_IS_HEADER, &is_header,
                      COL_IS_SEPARATOR, &is_separator, -1);
   return !is_header && !is_separator;
 }
 
 void AutoFillDialog::OnLinkActivated() {
   Browser* browser = BrowserList::GetLastActive();
-  browser->OpenURL(GURL(kAutoFillLearnMoreUrl), GURL(), NEW_FOREGROUND_TAB,
-                   PageTransition::TYPED);
+  if (!browser || !browser->GetSelectedTabContents())

[James Hawkins, 2010/10/09 00:22:52]

You DCHECK in the InfoBar code, yet check for |browser| here. Can the dialog be
open yet the browser is closed?

[dhollowa, 2010/10/09 00:32:07]

Yes.  I believe so.

[James Hawkins, 2010/10/09 00:47:36]

Under what circumstances?

[dhollowa, 2010/10/09 01:08:21]

[Associating reply... got move to top-level somehow].

I'd need to verify on Linux, but on Mac it is quite simple to open the Autofill
dialog and then close all open browser windows.  Then click the link on the
Autofill dialog.

+    browser = Browser::Create(profile_);
+  browser->OpenAutoFillHelpTabAndActivate();
 }
 
 void AutoFillDialog::LoadAutoFillData() {
   if (!personal_data_->IsDataLoaded()) {
     UpdateWidgetState();
     return;
   }
 
   // Rebuild the underlying store.
   gtk_list_store_clear(list_store_);
@@ skipping 278 matching lines @@
 
 void ShowAutoFillDialog(gfx::NativeView parent,
                         AutoFillDialogObserver* observer,
                         Profile* profile) {
   DCHECK(profile);
 
   if (!dialog)
     dialog = new AutoFillDialog(profile, observer);
   dialog->Show();
 }