Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: chrome/browser/autofill/autofill_dialog_gtk.cc

Issue 3645002: Autofill help link should link to locale specific site (Closed)
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_cc_infobar_delegate.cc ('k') | chrome/browser/autofill/autofill_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_dialog_gtk.cc
diff --git a/chrome/browser/autofill/autofill_dialog_gtk.cc b/chrome/browser/autofill/autofill_dialog_gtk.cc
index 1e6a12b8b84cbb881feeda333425b6829e9be9b4..bc305ff3da6a651d169d8f60fe70051d1b4e1712 100644
--- a/chrome/browser/autofill/autofill_dialog_gtk.cc
+++ b/chrome/browser/autofill/autofill_dialog_gtk.cc
@@ -366,8 +366,9 @@ gboolean AutoFillDialog::OnSelectionFilter(GtkTreeSelection* selection,
void AutoFillDialog::OnLinkActivated() {
Browser* browser = BrowserList::GetLastActive();
- browser->OpenURL(GURL(kAutoFillLearnMoreUrl), GURL(), NEW_FOREGROUND_TAB,
- PageTransition::TYPED);
+ if (!browser || !browser->GetSelectedTabContents())
James Hawkins 2010/10/09 00:22:52 You DCHECK in the InfoBar code, yet check for |bro
dhollowa 2010/10/09 00:32:07 Yes. I believe so.
James Hawkins 2010/10/09 00:47:36 Under what circumstances?
dhollowa 2010/10/09 01:08:21 [Associating reply... got move to top-level someho
+ browser = Browser::Create(profile_);
+ browser->OpenAutoFillHelpTabAndActivate();
}
void AutoFillDialog::LoadAutoFillData() {
« no previous file with comments | « chrome/browser/autofill/autofill_cc_infobar_delegate.cc ('k') | chrome/browser/autofill/autofill_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698