Issue 3620011: Fall back to our own codereview settings if a key is not found in gcl's settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3620011: Fall back to our own codereview settings if a key is not found in gcl's settings. (Closed)

Created:
10 years, 2 months ago by Bernhard Bauer

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Jói

Visibility:
Public.

Description

Fall back to our own codereview settings if a key is not found in gcl's settings. Otherwise, git try breaks for some users. Also, make testUpdateCheckout pass if the path to the temp directory contains a symlink (like on Mac OS X). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61786

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -14 lines)			Patch
M	gcl.py	View	1 chunk	+1 line, -1 line	1 comment	Download
M	tests/gclient_scm_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trychange.py	View	1 chunk	+13 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

BTW, I had some test failures on presubmit, but I think they were caused by ...

10 years, 2 months ago (2010-10-07 09:57:49 UTC) #2

Jói

Bernhard, sorry about breaking things for git users, and thanks for cleaning up after me. ...

10 years, 2 months ago (2010-10-07 13:42:26 UTC) #3

M-A Ruel

10 years, 2 months ago (2010-10-07 13:48:56 UTC) #4

lgtm, sorry for the delay

http://codereview.chromium.org/3620011/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/3620011/diff/1/2#newcode206
gcl.py:206: return CODEREVIEW_SETTINGS.get(key, '')
This doesn't change anything so remove it from this change. I would have left it
only if there was other changes in this file.

Expand Messages | Collapse Messages