gcl.py - Issue 3620011: Fall back to our own codereview settings if a key is not found in gcl's settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gcl.py

Issue 3620011: Fall back to our own codereview settings if a key is not found in gcl's settings. (Closed)

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gcl.py

diff --git a/gcl.py b/gcl.py

index e759970a80ccc09dcd4aaf1b999f58a0fd9fb86d..56ca2eca920aa6dd598e4c9f61358cb2405d40f4 100755

--- a/gcl.py

+++ b/gcl.py

@@ -203,7 +203,7 @@ def GetCodeReviewSetting(key):

k, v = line.split(':', 1)

CODEREVIEW_SETTINGS[k.strip()] = v.strip()

CODEREVIEW_SETTINGS.setdefault('__just_initialized', None)

- return CODEREVIEW_SETTINGS.get(key, "")

+ return CODEREVIEW_SETTINGS.get(key, '')

M-A Ruel 2010/10/07 13:48:56 This doesn't change anything so remove it from thi

def Warn(msg):

« no previous file with comments | « no previous file | tests/gclient_scm_test.py » ('j') | no next file with comments »