Fall back to our own codereview settings if a key is not found in gcl's settings.

gcl.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
@@ skipping 185 matching lines @@
       for line in settings_file.splitlines():
         if not line or line.startswith('#'):
           continue
         if not ':' in line:
           raise gclient_utils.Error(
               '%s is invalid, please fix. It\'s content:\n\n%s' %
                   (CODEREVIEW_SETTINGS_FILE, settings_file))
         k, v = line.split(':', 1)
         CODEREVIEW_SETTINGS[k.strip()] = v.strip()
     CODEREVIEW_SETTINGS.setdefault('__just_initialized', None)
-  return CODEREVIEW_SETTINGS.get(key, "")
+  return CODEREVIEW_SETTINGS.get(key, '')

[M-A Ruel, 2010/10/07 13:48:56]

This doesn't change anything so remove it from this change. I would have left it
only if there was other changes in this file.

 
 
 def Warn(msg):
   print >> sys.stderr, msg
 
 
 def ErrorExit(msg):
   print >> sys.stderr, msg
   sys.exit(1)
 
@@ skipping 1119 matching lines @@
     if e.code != 500:
       raise
     print >> sys.stderr, (
         'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
         'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
     return 1
 
 
 if __name__ == "__main__":
   sys.exit(main(sys.argv[1:]))