Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 3614010: Add WebP library to Chromium... (Closed)

Created:
10 years, 2 months ago by fbarchard
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pascal.massimino
Visibility:
Public.

Description

Add libwebp library source and gyp file. BUG=58225 TEST=library should build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61828

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : Add libwebp library source and gyp file. #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3695 lines, -1 line) Patch
M build/all.gyp View 5 6 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/libwebp/LICENSE View 1 2 3 4 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/libwebp/README.chromium View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/libwebp/bits.h View 1 2 3 4 1 chunk +106 lines, -0 lines 0 comments Download
A third_party/libwebp/bits.c View 1 2 3 4 1 chunk +78 lines, -0 lines 0 comments Download
A third_party/libwebp/dsp.c View 1 2 3 4 1 chunk +675 lines, -0 lines 0 comments Download
A third_party/libwebp/frame.c View 1 2 3 4 1 chunk +407 lines, -0 lines 0 comments Download
A third_party/libwebp/libwebp.gyp View 1 2 3 4 5 1 chunk +72 lines, -0 lines 0 comments Download
A third_party/libwebp/quant.c View 1 2 3 4 1 chunk +107 lines, -0 lines 0 comments Download
A third_party/libwebp/tree.c View 1 2 3 4 1 chunk +579 lines, -0 lines 0 comments Download
A third_party/libwebp/vp8.c View 1 2 3 4 1 chunk +600 lines, -0 lines 0 comments Download
A third_party/libwebp/vp8i.h View 1 2 3 4 1 chunk +318 lines, -0 lines 0 comments Download
A third_party/libwebp/webp.c View 1 chunk +361 lines, -0 lines 0 comments Download
A third_party/libwebp/webp/decode.h View 1 2 3 4 1 chunk +111 lines, -0 lines 0 comments Download
A third_party/libwebp/webp/decode_vp8.h View 1 2 3 4 1 chunk +107 lines, -0 lines 0 comments Download
A third_party/libwebp/yuv.h View 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/libwebp/yuv.c View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
fbarchard
Initial drop of libwebp for Chromium.
10 years, 2 months ago (2010-10-06 23:22:57 UTC) #1
Peter Kasting
Rubber-stamp LGTM. I still think we should pursue pulling this in via DEPS. http://codereview.chromium.org/3614010/diff/1/4 File ...
10 years, 2 months ago (2010-10-06 23:35:09 UTC) #2
fbarchard
Fixed the readme
10 years, 2 months ago (2010-10-07 01:00:13 UTC) #3
fbarchard
Removed duplicate conditional for win in libwebp.gyp and added all.gyp reference to libwebp. TBR=pkasting
10 years, 2 months ago (2010-10-07 15:57:59 UTC) #4
scherkus (not reviewing)
out of curiosity why didn't we go the DEPS route?
10 years, 2 months ago (2010-10-07 21:15:54 UTC) #5
pascal.massimino
Andrew, On Thu, Oct 7, 2010 at 2:15 PM, <scherkus@chromium.org> wrote: > out of curiosity ...
10 years, 2 months ago (2010-10-07 21:27:37 UTC) #6
darin (slow to review)
10 years, 2 months ago (2010-10-08 06:17:55 UTC) #7
The issue according to maruel is that while gclient supports pulling from
git repositories, depot_tools does not contain a git executable on windows,
so we aren't yet in a position to use git repositories for cross-platform
dependencies.

It would also be reasonable to host this library under
/trunk/deps/third_party/, and then pull it via DEPS.  That way, once we do
add git to depot_tools, we would be able to just change where DEPS points.
 But, I'm not sure this is enough of a reason to justify the work.

-darin



On Thu, Oct 7, 2010 at 2:27 PM, Pascal Massimino <pascal.massimino@gmail.com
> wrote:

> Andrew,
>
> On Thu, Oct 7, 2010 at 2:15 PM, <scherkus@chromium.org> wrote:
>
>> out of curiosity why didn't we go the DEPS route?
>
>
> right  now, the libwebp-decode is hosted by a git repo,
> whereas Chromium somehow prefers svn for DEPS. Can
> be worked around, but will take more time...
>
> skal
>

Powered by Google App Engine
This is Rietveld 408576698