Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 360050: Keep natives source code in external strings instead of putting... (Closed)

Created:
11 years, 1 month ago by Erik Corry
Modified:
11 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Keep natives source code in external strings instead of putting it in regular flat strings that are part of the snapshot. After this change we don't need libraries-empty.cc any more. In this change libraries-empty.cc is just a the same as libraries.cc and the scons build builds it but does not use it. We can move in stages to a situation where it is not generated at all for all the build systems that we have.

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -24 lines) Patch
M src/SConscript View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.h View 1 chunk +19 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 3 chunks +34 lines, -3 lines 0 comments Download
M src/objects.h View 1 5 chunks +12 lines, -2 lines 0 comments Download
M src/objects.cc View 1 3 chunks +33 lines, -7 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/serialize.h View 2 chunks +10 lines, -1 line 0 comments Download
M src/serialize.cc View 1 4 chunks +37 lines, -1 line 0 comments Download
M tools/js2c.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
11 years, 1 month ago (2009-11-05 13:03:21 UTC) #1
Mads Ager (chromium)
11 years, 1 month ago (2009-11-05 13:35:30 UTC) #2
LGTM

Does it lint? :-)

http://codereview.chromium.org/360050/diff/1/6
File src/bootstrapper.cc (right):

http://codereview.chromium.org/360050/diff/1/6#newcode104
Line 104: new
NativesExternalStringResource(Natives::GetScriptSource(index).start());
Line too long?

Do we ever delete these?  We should do something to eventually delete them. 
Otherwise we will get valgrind complaints.

http://codereview.chromium.org/360050/diff/1/6#newcode105
Line 105: Handle<String> source_code =
Factory::NewExternalStringFromAscii(resource);
Line too long?

http://codereview.chromium.org/360050/diff/1/5
File src/objects.cc (right):

http://codereview.chromium.org/360050/diff/1/5#newcode1143
Line 1143:
reinterpret_cast<ExternalAsciiString*>(this)->ExternalAsciiStringIterateBody(v);
Long lines?

http://codereview.chromium.org/360050/diff/1/5#newcode4413
Line 4413:
v->VisitExternalAsciiString(reinterpret_cast<Resource**>(FIELD_ADDR(this,
kResourceOffset)));
Long lines!

http://codereview.chromium.org/360050/diff/1/9
File src/serialize.cc (right):

http://codereview.chromium.org/360050/diff/1/9#newcode2066
Line 2066: new
NativesExternalStringResource(Natives::GetScriptSource(index).start());
Long line?

http://codereview.chromium.org/360050/diff/1/9#newcode2317
Line 2317: ExternalAsciiString* string =
reinterpret_cast<ExternalAsciiString*>(source);
Long line?

Powered by Google App Engine
This is Rietveld 408576698