Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: media/audio/linux/alsa_output.h

Issue 360042: First patch in making destructors of refcounted objects private. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/linux/alsa_output.h
===================================================================
--- media/audio/linux/alsa_output.h (revision 30973)
+++ media/audio/linux/alsa_output.h (working copy)
@@ -75,7 +75,6 @@
AlsaWrapper* wrapper,
AudioManagerLinux* manager,
MessageLoop* message_loop);
- virtual ~AlsaPcmOutputStream();
// Implementation of AudioOutputStream.
virtual bool Open(size_t packet_size);
@@ -86,6 +85,7 @@
virtual void GetVolume(double* left_level, double* right_level);
private:
+ friend class base::RefCountedThreadSafe<AlsaPcmOutputStream>;
friend class AlsaPcmOutputStreamTest;
FRIEND_TEST(AlsaPcmOutputStreamTest, AutoSelectDevice_DeviceSelect);
FRIEND_TEST(AlsaPcmOutputStreamTest, AutoSelectDevice_FallbackDevices);
@@ -106,6 +106,8 @@
FRIEND_TEST(AlsaPcmOutputStreamTest, WritePacket_StopStream);
FRIEND_TEST(AlsaPcmOutputStreamTest, WritePacket_WriteFails);
+ virtual ~AlsaPcmOutputStream();
+
// In-memory buffer to hold sound samples before pushing to the sound device.
// TODO(ajwong): There are now about 3 buffer/packet implementations. Factor
// them out.

Powered by Google App Engine
This is Rietveld 408576698