Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: ipc/ipc_sync_channel.h

Issue 360042: First patch in making destructors of refcounted objects private. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_sync_channel.h
===================================================================
--- ipc/ipc_sync_channel.h (revision 30973)
+++ ipc/ipc_sync_channel.h (working copy)
@@ -61,8 +61,6 @@
MessageLoop* ipc_thread,
base::WaitableEvent* shutdown_event);
- ~SyncContext();
-
// Adds information about an outgoing sync message to the context so that
// we know how to deserialize the reply.
void Push(IPC::SyncMessage* sync_msg);
@@ -97,6 +95,7 @@
}
private:
+ ~SyncContext();
M-A Ruel 2009/11/05 20:31:28 virtual
jam 2009/11/05 21:52:37 no need, nothing derives from this class.
awong 2009/11/05 21:58:39 It's already virtual because it's inheriting from
// IPC::ChannelProxy methods that we override.
// Called on the listener thread.

Powered by Google App Engine
This is Rietveld 408576698