Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: ipc/ipc_sync_channel.cc

Issue 360042: First patch in making destructors of refcounted objects private. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_sync_channel.cc
===================================================================
--- ipc/ipc_sync_channel.cc (revision 30973)
+++ ipc/ipc_sync_channel.cc (working copy)
@@ -51,9 +51,6 @@
return rv;
}
- ~ReceivedSyncMsgQueue() {
- }
-
// Called on IPC thread when a synchronous message or reply arrives.
void QueueMessage(const Message& msg, SyncChannel::SyncContext* context) {
bool was_task_pending;
@@ -157,6 +154,8 @@
}
private:
+ friend class base::RefCountedThreadSafe<ReceivedSyncMsgQueue>;
+
// See the comment in SyncChannel::SyncChannel for why this event is created
// as manual reset.
ReceivedSyncMsgQueue() :
@@ -167,6 +166,8 @@
top_send_done_watcher_(NULL) {
}
+ ~ReceivedSyncMsgQueue() {}
+
// Holds information about a queued synchronous message or reply.
struct QueuedMessage {
QueuedMessage(Message* m, SyncContext* c) : message(m), context(c) { }

Powered by Google App Engine
This is Rietveld 408576698