Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 360011: Obey the flag --lazy in the toplevel code generator.... (Closed)

Created:
11 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Obey the flag --lazy in the toplevel code generator. There were two separate implementations of the function 'BuildBoilerplate' that is used to compile function declarations and function literals. The implementations did not do exactly the same thing. In particular, one ignored the flag --lazy. Combine the two implementations. Committed: http://code.google.com/p/v8/source/detail?r=3218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -160 lines) Patch
M src/arm/codegen-arm.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/arm/fast-codegen-arm.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.cc View 3 chunks +3 lines, -94 lines 0 comments Download
M src/compiler.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/compiler.cc View 2 chunks +105 lines, -1 line 0 comments Download
M src/fast-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/fast-codegen.cc View 5 chunks +8 lines, -40 lines 0 comments Download
M src/handles.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/handles.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.h View 2 chunks +1 line, -8 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/x64/codegen-x64.h View 2 chunks +1 line, -8 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 1 month ago (2009-11-04 16:52:39 UTC) #1
fschneider
11 years, 1 month ago (2009-11-04 17:50:44 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698