Issue 3597001: Move vm constants into their own file. This will make it easier to share these constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3597001: Move vm constants into their own file. This will make it easier to share these constants. (Closed)

Created:
10 years, 2 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov, rtc

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Move vm constants into their own file. This will make it easier to share these constants. Also fixed get latest image logic in image_to_vm and allowed for using the most recent image in cros_run_vm_test to follow other shell convention of using latest. Change-Id: I60ed4c03d609500da7f6ae34ef57ba2e32f4b0bb BUG= TEST=Tested by running image_to_vm with --full and cros_run_vm_test with suite_Smoke Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=45bec93

Patch Set 1 #

Patch Set 2 : Fix ws #

Total comments: 3

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -17 lines)			Patch
M	bin/cros_run_vm_test	View	1	2 chunks	+11 lines, -2 lines	2 comments	Download
M	image_to_vm.sh	View		2 chunks	+2 lines, -13 lines	0 comments	Download
A	lib/cros_vm_constants.sh	View	1	1 chunk	+16 lines, -0 lines	1 comment	Download
M	lib/cros_vm_lib.sh	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 2 months ago (2010-09-29 20:54:07 UTC) #2

LGTM w/ some nits.

http://codereview.chromium.org/3597001/diff/2001/3001
File bin/cros_run_vm_test (right):

http://codereview.chromium.org/3597001/diff/2001/3001#newcode11
bin/cros_run_vm_test:11: . "$(dirname "$0")/../lib/cros_vm_constants.sh"
why "$0" and not in the rest?

http://codereview.chromium.org/3597001/diff/2001/3001#newcode26
bin/cros_run_vm_test:26: FLAGS_image_path=${LATEST_IMAGE}
If no images or image dir, you'd be looking at "/${DEFAULT_QEMU_IMAGE}".
Desired?

http://codereview.chromium.org/3597001/diff/2001/3003
File lib/cros_vm_constants.sh (right):

http://codereview.chromium.org/3597001/diff/2001/3003#newcode16
lib/cros_vm_constants.sh:16: MIN_STATEFUL_FS_SIZE_FULL=2048
consider including VM somewhere in all of these constant names (or something
related to VM).

Expand Messages | Collapse Messages