Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: lib/cros_vm_lib.sh

Issue 3597001: Move vm constants into their own file. This will make it easier to share these constants. (Closed) Base URL: http://git.chromium.org/git/crosutils.git
Patch Set: Fix ws Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/cros_vm_constants.sh ('K') | « lib/cros_vm_constants.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/cros_vm_lib.sh
diff --git a/lib/cros_vm_lib.sh b/lib/cros_vm_lib.sh
index 61d575bfff6bd4b9197f230d8e07163e30547670..c47d11de33bb01c4375dbbab6a0a02b0559f6ac8 100644
--- a/lib/cros_vm_lib.sh
+++ b/lib/cros_vm_lib.sh
@@ -4,6 +4,8 @@
#
# Common vm functions for use in crosutils.
+. "$(dirname "$0")/cros_vm_constants.sh"
+
DEFINE_string kvm_pid "" \
"Use this pid file. If it exists and is set, use the vm specified by pid."
DEFINE_boolean no_graphics ${FLAGS_FALSE} "Runs the KVM instance silently."
@@ -11,7 +13,6 @@ DEFINE_boolean persist "${FLAGS_FALSE}" "Persist vm."
DEFINE_boolean snapshot ${FLAGS_FALSE} "Don't commit changes to image."
DEFINE_integer ssh_port 9222 "Port to tunnel ssh traffic over."
-
KVM_PID_FILE=/tmp/kvm.$$.pid
function get_pid() {
@@ -47,7 +48,7 @@ function start_kvm() {
snapshot="-snapshot"
fi
- sudo kvm -m 1024 \
+ sudo kvm -m ${DEFAULT_MEM} \
-vga std \
-pidfile "${KVM_PID_FILE}" \
-daemonize \
« lib/cros_vm_constants.sh ('K') | « lib/cros_vm_constants.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698