Move vm constants into their own file. This will make it easier to share these constants.

bin/cros_run_vm_test

 #!/bin/bash
 
 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Runs a given test case under a VM.
 
 . "$(dirname $0)/../common.sh"
 . "$(dirname $0)/../lib/cros_vm_lib.sh"
+. "$(dirname "$0")/../lib/cros_vm_constants.sh"

[petkov, 2010/09/29 20:54:07]

why "$0" and not in the rest?

 
 DEFINE_string image_path "" "Full path of the VM image"
 DEFINE_string test_case "" "Name of the test case to run"
 
 set -e
 
 # Parse command line.
 FLAGS "$@" || exit 1
 eval set -- "${FLAGS_ARGV}"
 
-[ -n "${FLAGS_image_path}" ] || die "You must specify a path to an image"
-[ -n "${FLAGS_test_case}" ] || die "You must specify a test case"
+# Use latest if not specified.
+if [ -z "${FLAGS_image_path}" ]; then
+  LATEST_IMAGE="$(${SCRIPTS_DIR}/get_latest_image.sh)/${DEFAULT_QEMU_IMAGE}"
+  info "Using latest vm image ${LATEST_IMAGE}"
+  FLAGS_image_path=${LATEST_IMAGE}

[petkov, 2010/09/29 20:54:07]

If no images or image dir, you'd be looking at "/${DEFAULT_QEMU_IMAGE}".
Desired?

+fi
+
+[ -e "${FLAGS_image_path}" ] || die "Image ${FLAGS_image_path} does not exist."
+
+[ -n "${FLAGS_test_case}" ] || die "You must specify a test case."
 
 trap stop_kvm EXIT
 start_kvm "${FLAGS_image_path}"
 "$(dirname $0)"/../run_remote_tests.sh \
   --ssh_port=${FLAGS_ssh_port} \
   --remote="${HOSTNAME}" \
   "${FLAGS_test_case}"